-
-
Notifications
You must be signed in to change notification settings - Fork 4.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Rename PretestEngineService to QuestionPlayerEngineService #6913
Conversation
Adding @vinitamurthi and @ankita240796 as initial reviewers (@vinitamurthi for the full PR, @ankita240796 for the typescript fix in extensions/classifiers/WinnowingPreprocessingService.ts). Also @sophiewu6 please checkout a fresh copy of package-lock.json and push that, thanks! (In general if package.json is not modified there should be no modification to package-lock.json. I think @apb7 or @NishealJ is working on tooling for fixing this automatically.) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, for the type error fix! Thanks, @sophiewu6!
…engine-service
Codecov Report
@@ Coverage Diff @@
## develop #6913 +/- ##
=======================================
Coverage 95.5% 95.5%
=======================================
Files 371 371
Lines 51058 51058
=======================================
Hits 48762 48762
Misses 2296 2296 Continue to review full report at Codecov.
|
Codecov Report
@@ Coverage Diff @@
## develop #6913 +/- ##
========================================
Coverage 95.68% 95.68%
========================================
Files 371 371
Lines 51429 51429
========================================
Hits 49212 49212
Misses 2217 2217 Continue to review full report at Codecov.
|
Hi @seanlip For some reason my local stack won't be able to start because of npm errors if I'm using the original package-lock.json, so I had to delete it and generate a new one. Any idea why that happens? |
There is an issue with package-lock.json where it unfortunately generates a different version for Mac vs Linux platforms. See #6736 |
@seanlip I understand that but why does the original package-lock.json file cause npm errors for me? It stopped me from starting the local stack. |
That, I am afraid I do not know, sorry. Have you file an issue for that with the error trace? |
@seanlip Not yet. I'll do that. I just realized that I can't even push the reverted version of package-lock.json because it stops me from running any script, including frontend tests, and the tests will be run automatically before pushing. |
I see, OK. Let's keep what you have here, then, but /cc @oppia/dev-workflow-team and especially @apb7 for info. |
@sophiewu6 @seanlip I have a hack for this, but it's unsafe |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good! @aks681 could you also take a look? We are making the PretestEngineService a more generic one for the question player. Eventually we will move the pretest also to use the question player directive.
…engine-service
Hi @seanlip I have pushed the reverted version of package-lock.json to this PR and the other one. |
@aks681 @prasanna08 PTAL, this PR needs your approval to get merged. Thanks! |
@aks681 PTAL, thanks! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM.
Explanation
Since PretestEngineService is not only used by pretest but also by review test and practice sessions, its name should be changed.