Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix part of #6732: Migrate value_generators to webpack #6900

Merged
merged 3 commits into from
Jun 11, 2019
Merged

Fix part of #6732: Migrate value_generators to webpack #6900

merged 3 commits into from
Jun 11, 2019

Conversation

vojtechjelinek
Copy link
Contributor

@vojtechjelinek vojtechjelinek commented Jun 10, 2019 •
edited
Loading

Explanation

Fixes part of #6732: Use webpack for importing value generators.

Checklist

  • The PR title starts with "Fix #bugnum: ", followed by a short, clear summary of the changes. (If this PR fixes part of an issue, prefix the title with "Fix part of #bugnum: ...".)
  • The PR explanation includes the words "Fixes #bugnum: ..." (or "Fixes part of #bugnum" if the PR only partially fixes an issue).
  • The linter/Karma presubmit checks have passed.
    • These should run automatically, but if not, you can manually trigger them locally using python scripts/pre_commit_linter.py and bash scripts/run_frontend_tests.sh.
  • The PR is made from a branch that's not called "develop".
  • The PR has an appropriate "CHANGELOG: ..." label (If you are unsure of which label to add, ask the reviewers for guidance).
  • The PR follows the style guide.
  • The PR addresses the points mentioned in the codeowner checks for the files/folders changed. (See the codeowner's wiki page.)
  • The PR is assigned to an appropriate reviewer.
    • If you're a new contributor, please ask on Gitter for someone to assign a reviewer and don't tick this checkbox.
    • If you're not sure who the appropriate reviewer is, please assign to the issue's "owner" -- see the "talk-to" label on the issue. Do not only request the review but also add the reviewer as an assignee.

@vojtechjelinek vojtechjelinek mentioned this pull request Jun 10, 2019
Closed
8 tasks
@vojtechjelinek
Copy link
Contributor Author

@kevinlee12 Can you test this, please?

@seanlip PTAL

@oppiabot
Copy link

oppiabot bot commented Jun 11, 2019

Hi @vojtechjelinek. Due to recent changes in the "develop" branch, this PR now has a merge conflict. Please follow this link if you need help resolving the conflict, so that the PR can be merged. Thanks!

kevinlee12
kevinlee12 approved these changes Jun 11, 2019
View reviewed changes
Copy link
Contributor

@kevinlee12 kevinlee12 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm on functionality!

seanlip
seanlip approved these changes Jun 11, 2019
View reviewed changes
Copy link
Member

@seanlip seanlip left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks @vojtechjelinek!

@YashJipkate -- FYI, do you have any naming rules for the "requires" files (value_generators/valueGeneratorsRequires.ts)? Probably worth addressing in separate pass, but wanted to give you a heads-up.

@seanlip
Copy link
Member

seanlip commented Jun 11, 2019

Also @vojtechjelinek please note the merge conflicts.

@codecov
Copy link

codecov bot commented Jun 11, 2019 •
edited
Loading

Codecov Report

Merging #6900 into develop will decrease coverage by <.01%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff             @@
##           develop    #6900      +/-   ##
===========================================
- Coverage    95.19%   95.19%   -0.01%     
===========================================
  Files          371      371              
  Lines        50432    50419      -13     
===========================================
- Hits         48008    47995      -13     
  Misses        2424     2424
Impacted Files Coverage Δ
core/controllers/editor.py 82.28% <ø> (-0.35%) ⬇️
core/domain/value_generators_domain.py 100% <ø> (ø) ⬆️
...ensions/value_generators/models/generators_test.py 100% <ø> (ø) ⬆️
core/controllers/admin.py 72.86% <ø> (-0.28%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 95dad90...7749f4a. Read the comment docs.

@vojtechjelinek
Copy link
Contributor Author

@seanlip Can we merge this?

@seanlip seanlip merged commit bd95914 into oppia:develop Jun 11, 2019
@vojtechjelinek vojtechjelinek deleted the webpack-extensions-value_generators branch January 26, 2020 18:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@seanlip seanlip seanlip approved these changes

@kevinlee12 kevinlee12 kevinlee12 approved these changes

@ankita240796 ankita240796 Awaiting requested review from ankita240796

@DubeySandeep DubeySandeep Awaiting requested review from DubeySandeep

Assignees

@kevinlee12 kevinlee12

@seanlip seanlip

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@vojtechjelinek @seanlip @kevinlee12