Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix part of #6732: Migrate RTCs to webpack #6882

Merged
merged 10 commits into from
Jun 10, 2019
Merged

Fix part of #6732: Migrate RTCs to webpack #6882

merged 10 commits into from
Jun 10, 2019

Conversation

vojtechjelinek
Copy link
Contributor

@vojtechjelinek vojtechjelinek commented Jun 9, 2019 •
edited
Loading

Explanation

Fixes part of #6732: Use webpack for importing Rich Text Components used in CKEditor.

Checklist

  • The PR title starts with "Fix #bugnum: ", followed by a short, clear summary of the changes. (If this PR fixes part of an issue, prefix the title with "Fix part of #bugnum: ...".)
  • The PR explanation includes the words "Fixes #bugnum: ..." (or "Fixes part of #bugnum" if the PR only partially fixes an issue).
  • The linter/Karma presubmit checks have passed.
    • These should run automatically, but if not, you can manually trigger them locally using python scripts/pre_commit_linter.py and bash scripts/run_frontend_tests.sh.
  • The PR is made from a branch that's not called "develop".
  • The PR has an appropriate "CHANGELOG: ..." label (If you are unsure of which label to add, ask the reviewers for guidance).
  • The PR follows the style guide.
  • The PR addresses the points mentioned in the codeowner checks for the files/folders changed. (See the codeowner's wiki page.)
  • The PR is assigned to an appropriate reviewer.
    • If you're a new contributor, please ask on Gitter for someone to assign a reviewer and don't tick this checkbox.
    • If you're not sure who the appropriate reviewer is, please assign to the issue's "owner" -- see the "talk-to" label on the issue. Do not only request the review but also add the reviewer as an assignee.

@vojtechjelinek
Copy link
Contributor Author

@kevinlee12 Can you QA this for me?

@kevinlee12
Copy link
Contributor

Sure!

@kevinlee12
Copy link
Contributor

Here's the test update (as a git patch). It's a looser test than that we have originally (we're checking if the file is there, but not the path), but let me know if we want to tighten it. 0001-Change-test_html_contains_all_imports-so-that-it-loo.patch.zip

@kevinlee12
Copy link
Contributor

Functionality-wise, this PR looks good!

@seanlip
Copy link
Member

seanlip commented Jun 10, 2019

Hm @vojtechjelinek the backend tests are failing?

@kevinlee12
Copy link
Contributor

@seanlip, it's because the expectations are different now, that's why I made that patch to change the test.

seanlip
seanlip approved these changes Jun 10, 2019
View reviewed changes
Copy link
Member

@seanlip seanlip left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah ok. LGTM otherwise :)

@vojtechjelinek
Copy link
Contributor Author

@seanlip After the test is fixed can we merge this without the code owners? it is kind of priority for the Angular migration.

@seanlip
Copy link
Member

seanlip commented Jun 10, 2019

Yes if you're confident on the QA/manual-testing front.

@vojtechjelinek vojtechjelinek mentioned this pull request Jun 10, 2019
Closed
8 tasks
kevinlee12
kevinlee12 approved these changes Jun 10, 2019
View reviewed changes
Copy link
Contributor

@kevinlee12 kevinlee12 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm from functionality!

@seanlip
Copy link
Member

seanlip commented Jun 10, 2019

@vojtechjelinek just to confirm -- should I merge this? Let me know once you're ready (and the tests pass).

@kevinlee12 kevinlee12 mentioned this pull request Jun 10, 2019
Merged
8 tasks
@vojtechjelinek
Copy link
Contributor Author

@seanlip Yes, please.

@seanlip
Copy link
Member

seanlip commented Jun 10, 2019

OK, merging, thanks!

@seanlip seanlip merged commit c2b1fa3 into oppia:develop Jun 10, 2019
@vojtechjelinek vojtechjelinek deleted the webpack-extensions branch September 10, 2019 13:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@seanlip seanlip seanlip approved these changes

@kevinlee12 kevinlee12 kevinlee12 approved these changes

@aks681 aks681 Awaiting requested review from aks681

@AllanYangZhou AllanYangZhou Awaiting requested review from AllanYangZhou

@ankita240796 ankita240796 Awaiting requested review from ankita240796

@apb7 apb7 Awaiting requested review from apb7

@bansalnitish bansalnitish Awaiting requested review from bansalnitish

@DubeySandeep DubeySandeep Awaiting requested review from DubeySandeep

@nithusha21 nithusha21 Awaiting requested review from nithusha21

@vinitamurthi vinitamurthi Awaiting requested review from vinitamurthi

Assignees

@kevinlee12 kevinlee12

@seanlip seanlip

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@vojtechjelinek @kevinlee12 @seanlip