Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix #6262: Constrain the width of the tooltip so that it fits the screen (instead of overflowing) #6865

Merged
merged 2 commits into from
Jun 19, 2019
Merged

Fix #6262: Constrain the width of the tooltip so that it fits the screen (instead of overflowing) #6865

merged 2 commits into from
Jun 19, 2019

Conversation

mertdeg2
Copy link
Contributor

@mertdeg2 mertdeg2 commented Jun 7, 2019 •
edited
Loading

Fix #6262: I have manually tested and verified that the tooltip is fully visible.

image

Checklist

  • The PR title starts with "Fix #bugnum: ", followed by a short, clear summary of the changes. (If this PR fixes part of an issue, prefix the title with "Fix part of #bugnum: ...".)
  • The PR explanation includes the words "Fixes #bugnum: ..." (or "Fixes part of #bugnum" if the PR only partially fixes an issue).
  • The linter/Karma presubmit checks have passed.
    • These should run automatically, but if not, you can manually trigger them locally using python scripts/pre_commit_linter.py and bash scripts/run_frontend_tests.sh.
  • The PR is made from a branch that's not called "develop".
  • The PR has an appropriate "CHANGELOG: ..." label (If you are unsure of which label to add, ask the reviewers for guidance).
  • The PR follows the style guide.
  • The PR addresses the points mentioned in the codeowner checks for the files/folders changed. (See the codeowner's wiki page.)
  • The PR is assigned to an appropriate reviewer.
    • If you're a new contributor, please ask on Gitter for someone to assign a reviewer and don't tick this checkbox.
    • If you're not sure who the appropriate reviewer is, please assign to the issue's "owner" -- see the "talk-to" label on the issue. Do not only request the review but also add the reviewer as an assignee.

@mertdeg2
Fix for oppia#6262
bd0db3f 
I have manually tested and verified that the tooltip is fully visible.
@mertdeg2 mertdeg2 requested a review from DubeySandeep as a code owner June 7, 2019 22:34
@seanlip
Copy link
Member

seanlip commented Jun 7, 2019

Oh, also, @mertdeg2 -- could you please update the title of the PR following the instructions here?

Next time please keep the PR checklist in your initial message body, too, and make sure you've done all the steps you can. Thanks!

@codecov
Copy link

codecov bot commented Jun 8, 2019

Codecov Report

Merging #6865 into develop will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff            @@
##           develop    #6865   +/-   ##
========================================
  Coverage    94.99%   94.99%           
========================================
  Files          371      371           
  Lines        50628    50628           
========================================
  Hits         48094    48094           
  Misses        2534     2534

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d5af34b...bd0db3f. Read the comment docs.

@codecov
Copy link

codecov bot commented Jun 8, 2019 •
edited
Loading

Codecov Report

Merging #6865 into develop will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff            @@
##           develop    #6865   +/-   ##
========================================
  Coverage    95.68%   95.68%           
========================================
  Files          371      371           
  Lines        51429    51429           
========================================
  Hits         49212    49212           
  Misses        2217     2217

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3069fe6...968888e. Read the comment docs.

DubeySandeep
DubeySandeep approved these changes Jun 8, 2019
View reviewed changes
Copy link
Member

@DubeySandeep DubeySandeep left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@mertdeg2, Thanks for the PR. LGTM! :)

Also, I've added the Checklist above can you please make sure that the first two points are followed? Thanks!

@oppiabot
Copy link

oppiabot bot commented Jun 11, 2019

Hi @mertdeg2. Due to recent changes in the "develop" branch, this PR now has a merge conflict. Please follow this link if you need help resolving the conflict, so that the PR can be merged. Thanks!

@mertdeg2 mertdeg2 changed the title Fix for #6262 Fix #6262: Constrain the width of the tooltip so that it fits the screen (instead of overflowing) Jun 14, 2019
@DubeySandeep DubeySandeep merged commit 6cb896f into oppia:develop Jun 19, 2019
nithusha21 pushed a commit that referenced this pull request Jul 1, 2019
@mertdeg2 @nithusha21
Fix #6262: Constrain the width of the tooltip so that it fits the scr…
c8bd94c 
…een (#6865)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@DubeySandeep DubeySandeep DubeySandeep approved these changes

@seanlip seanlip seanlip approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

The help tooltip text is not fully visible
5 participants
@mertdeg2 @seanlip @DubeySandeep @nithusha21 @aks681