Upgrades jasmine, karma-webpack, webdriver-manager, covergae, pygithub & webpack to their latest version #6770

NishealJ · 2019-05-21T14:48:43Z

Explanation

This PR upgrades jasmine, karma-webpack, webdriver-manager & webpack to their latest version.
Visit here to see the upgrade status of all the oppia third-party libraries.

visit here for testing doc

Checklist

The PR title starts with "Fix #bugnum: ", followed by a short, clear summary of the changes. (If this PR fixes part of an issue, prefix the title with "Fix part of #bugnum: ...".)
The PR explanation includes the words "Fixes #bugnum: ..." (or "Fixes part of #bugnum" if the PR only partially fixes an issue).
The linter/Karma presubmit checks have passed.
- These should run automatically, but if not, you can manually trigger them locally using python scripts/pre_commit_linter.py and bash scripts/run_frontend_tests.sh.
The PR is made from a branch that's not called "develop".
The PR has an appropriate "CHANGELOG: ..." label (If you are unsure of which label to add, ask the reviewers for guidance).
The PR follows the style guide.
The PR addresses the points mentioned in the codeowner checks for the files/folders changed. (See the codeowner's wiki page.)
The PR is assigned to an appropriate reviewer.
- If you're a new contributor, please ask on Gitter for someone to assign a reviewer.
- If you're not sure who the appropriate reviewer is, please assign to the issue's "owner" -- see the "talk-to" label on the issue.

…_webpack

apb7

Hi @NishealJ, thanks for the PR. Can you please list the testing methodology for this (and other upgrade PRs)?

apb7 · 2019-05-21T15:24:44Z

package-lock.json

        "eslint-scope": "^4.0.0",
        "eslint-visitor-keys": "^1.0.0"
-      },
-      "dependencies": {
-        "eslint-scope": {


Hi @NishealJ, I have a couple of questions here:

There seem to be deletions in this file. Is this the case or have some dependencies been moved? If the latter, please revert them to their original positions.

There are multiple versions of eslint-scope listed in this file as dependencies (4.0.3 and 3.7.1). Why? Are there any other such dependencies? Can you please check this?

Hi @apb7,
yes, I'll provide the testing docs for this.
package-lock.json was auto-generated after the upgrade, I believe there are deletions in package-lock.json because, after the upgrade, libraries might have changed their requirements.
Also,
eslint-scope is mentioned twice because package-lock contains all the libraries and their requirements, if 2 or more libraries require eslint-scope it will be mentioned more than 2 time.

I'll completely test this and provide a testing doc thanks!

yes, I'll provide the testing docs for this.

Hmm. I was looking for the manual tests you must have carried out locally when upgrading this.

package-lock.json was auto-generated after the upgrade, I believe there are deletions in package-lock.json because, after the upgrade, libraries might have changed their requirements.

Okay, thanks for the explanation.

eslint-scope is mentioned twice because package-lock contains all the libraries and their requirements, if 2 or more libraries require eslint-scope it will be mentioned more than 2 time.

I agree -- if there are two or more libraries that require eslint-scope, it will be mentioned more than two times. I was more concerned regarding two different versions of eslint-scope...

I'll completely test this and provide a testing doc thanks!

Okay, if this PR is untested, can you please do the following:

Label this as a WIP and add to the PR explanation whatever is left to do.

Assign the PR to yourself until it remains a WIP. As soon as you are done with the PR, please re-assign it to me so that I can review it.

Thanks!

apb7 · 2019-05-21T15:29:41Z

Oh, and also, is this PR dependent on or related to PR #6769? I can see some overlapping changes in package-lock.json. Thanks!

oppiabot · 2019-05-21T15:58:33Z

Hi @NishealJ. Due to recent changes in the "develop" branch, this PR now has a merge conflict. Please follow this link if you need help resolving the conflict, so that the PR can be merged. Thanks!

oppiabot · 2019-06-03T06:54:59Z

Hi @NishealJ, I'm going to mark this PR as stale because it hasn't had any updates for 10 days. If no further activity occurs within 7 days, it will be automatically closed so that others can take up the issue.
If you are still working on this PR, please make a follow-up commit within 7 days (and submit it for review, if applicable). Please also let us know if you are stuck so we can help you!

NishealJ · 2019-06-14T09:05:40Z

Hi @NishealJ any progress on this?

Hi @lilithxxx, i'm working on the testing doc.

apb7 · 2019-06-15T08:49:02Z

@NishealJ, since you're upgrading multiple libraries here, please change the PR title accordingly. Thanks!

NishealJ · 2019-06-16T10:18:32Z

@NishealJ, since you're upgrading multiple libraries here, please change the PR title accordingly. Thanks!

Done @apb7

NishealJ · 2019-06-17T21:57:49Z

Hi @apb7,
This PR has upgrades libs with minor version changes I've analyzed through changelogs for testing whereas few libs have only bug fix in their changelog.
here is the testing doc, please let me know if you need tests for an intended behavior Thanks :)

seanlip · 2019-06-17T21:59:03Z

Hi @NishealJ, two things -- please make the doc commentable by anyone, and please also make sure the doc contains links to the changelogs for the relevant libraries and calls out + analyzes any breaking changes. Thanks!

NishealJ · 2019-06-17T22:01:30Z

Hi @NishealJ, two things -- please make the doc commentable by anyone, and please also make sure the doc contains links to the changelogs for the relevant libraries and calls out + analyzes any breaking changes. Thanks!

Sure @seanlip Thanks i've updated

apb7

LGTM, thanks @NishealJ. Please check out a fresh copy of package-lock.json (if it isn't already).

apb7 · 2019-06-18T07:04:17Z

Hi @seanlip and @vojtechjelinek, ptal as code owners. Thanks!

NishealJ · 2019-06-18T07:12:49Z

LGTM, thanks @NishealJ. Please check out a fresh copy of package-lock.json (if it isn't already).

Hi @apb7, I've checked it, its fresh no changes with start.sh and it has no fsevents Thanks!

Edit: Updated package-lock.json

vojtechjelinek

The package-lock.json shouldn't be empty, otherwise LGTM!

NishealJ · 2019-06-18T08:40:34Z

The package-lock.json shouldn't be empty, otherwise LGTM!

Hi @vojtechjelinek Done Thanks!

NishealJ · 2019-06-19T07:06:15Z

Hi @vojtechjelinek & @seanlip PTAL Thanks!

apb7 · 2019-06-20T10:57:57Z

Hi @vojtechjelinek, ptal. Thanks!

vojtechjelinek

LGTM!

NishealJ added 13 commits May 11, 2019 00:02

for travis

751d99d

for travis 2

e4564fa

for travis 2

6f74ccd

for travis 2

3319edd

set circle ci

88d0039

set circle ci 2

a623021

Rever travis and circle

5d30cf8

Merge branch 'develop' of https://github.com/oppia/oppia into develop

d5d700f

Merge branch 'develop' of https://github.com/oppia/oppia into develop

7ba9021

Initial upgrade

4c863b6

Remove un-necc

dac2d12

Merge branch 'develop' of https://github.com/oppia/oppia into develop

b78c203

Merge branch 'develop' of https://github.com/NishealJ/oppia into nm_u…

5646bf9

…_webpack

NishealJ requested review from seanlip and apb7 May 21, 2019 14:48

NishealJ requested a review from vojtechjelinek as a code owner May 21, 2019 14:48

apb7 suggested changes May 21, 2019

View reviewed changes

oppiabot bot added the PR: don't merge - HAS MERGE CONFLICTS label May 21, 2019

NishealJ added 3 commits May 21, 2019 21:30

Merge branch 'develop' of https://github.com/oppia/oppia into develop

c1b3e6b

Resolve conflicts

38b2219

Reslove conflict

3367dda

NishealJ removed the PR: don't merge - HAS MERGE CONFLICTS label May 21, 2019

apb7 assigned NishealJ May 21, 2019

NishealJ added PR: don't merge - UNTESTED labels May 21, 2019

NishealJ added 2 commits May 23, 2019 22:56

Revert webdriver-manager

9ae1d54

Upgrade webdriver-manager to 12.1.4

1ce2578

NishealJ changed the title ~~Upgrades jasmine, karma-webpack, webdriver-manager & webpack to their latest version~~ Upgrades jasmine, karma-webpack, webdriver-manager, covergae, pygithub & webpack to their latest version Jun 16, 2019

apb7 added the CHANGELOG: Code health label Jun 17, 2019

Fix merge

a08b1af

NishealJ removed the PR: don't merge - HAS MERGE CONFLICTS label Jun 17, 2019

NishealJ removed PR: don't merge - UNTESTED labels Jun 17, 2019

apb7 approved these changes Jun 18, 2019

View reviewed changes

apb7 assigned vojtechjelinek and seanlip and unassigned NishealJ Jun 18, 2019

vojtechjelinek suggested changes Jun 18, 2019

View reviewed changes

NishealJ added 2 commits June 18, 2019 11:32

Merge remote-tracking branch 'origin/develop' into nm_u_webpack

e46fb5f

Update Package-lock

31185ae

seanlip approved these changes Jun 19, 2019

View reviewed changes

seanlip removed their assignment Jun 19, 2019

NishealJ requested a review from vojtechjelinek June 20, 2019 06:11

apb7 removed the request for review from vojtechjelinek June 20, 2019 10:56

vojtechjelinek approved these changes Jun 20, 2019

View reviewed changes

vojtechjelinek merged commit b01bd3b into oppia:develop Jun 20, 2019

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Upgrades jasmine, karma-webpack, webdriver-manager, covergae, pygithub & webpack to their latest version #6770

Upgrades jasmine, karma-webpack, webdriver-manager, covergae, pygithub & webpack to their latest version #6770

NishealJ commented May 21, 2019 •

edited

Loading

apb7 left a comment

apb7 May 21, 2019

NishealJ May 21, 2019

apb7 May 21, 2019

apb7 commented May 21, 2019

oppiabot bot commented May 21, 2019

oppiabot bot commented Jun 3, 2019

NishealJ commented Jun 14, 2019

apb7 commented Jun 15, 2019

NishealJ commented Jun 16, 2019

NishealJ commented Jun 17, 2019 •

edited

Loading

seanlip commented Jun 17, 2019

NishealJ commented Jun 17, 2019

apb7 left a comment

apb7 commented Jun 18, 2019

NishealJ commented Jun 18, 2019 •

edited

Loading

vojtechjelinek left a comment

NishealJ commented Jun 18, 2019 •

edited

Loading

NishealJ commented Jun 19, 2019

apb7 commented Jun 20, 2019

vojtechjelinek left a comment

Upgrades jasmine, karma-webpack, webdriver-manager, covergae, pygithub & webpack to their latest version #6770

Upgrades jasmine, karma-webpack, webdriver-manager, covergae, pygithub & webpack to their latest version #6770

Conversation

NishealJ commented May 21, 2019 • edited Loading

Explanation

Checklist

apb7 left a comment

Choose a reason for hiding this comment

apb7 May 21, 2019

Choose a reason for hiding this comment

NishealJ May 21, 2019

Choose a reason for hiding this comment

apb7 May 21, 2019

Choose a reason for hiding this comment

apb7 commented May 21, 2019

oppiabot bot commented May 21, 2019

oppiabot bot commented Jun 3, 2019

NishealJ commented Jun 14, 2019

apb7 commented Jun 15, 2019

NishealJ commented Jun 16, 2019

NishealJ commented Jun 17, 2019 • edited Loading

seanlip commented Jun 17, 2019

NishealJ commented Jun 17, 2019

apb7 left a comment

Choose a reason for hiding this comment

apb7 commented Jun 18, 2019

NishealJ commented Jun 18, 2019 • edited Loading

vojtechjelinek left a comment

Choose a reason for hiding this comment

NishealJ commented Jun 18, 2019 • edited Loading

NishealJ commented Jun 19, 2019

apb7 commented Jun 20, 2019

vojtechjelinek left a comment

Choose a reason for hiding this comment

NishealJ commented May 21, 2019 •

edited

Loading

NishealJ commented Jun 17, 2019 •

edited

Loading

NishealJ commented Jun 18, 2019 •

edited

Loading

NishealJ commented Jun 18, 2019 •

edited

Loading