Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix #6562: Removed G+ from the footer and Readme.md #6569

Merged
merged 2 commits into from
Apr 9, 2019
Merged

Fix #6562: Removed G+ from the footer and Readme.md #6569

merged 2 commits into from
Apr 9, 2019

Conversation

ShubhamBansal1997
Copy link
Contributor

@ShubhamBansal1997 ShubhamBansal1997 commented Apr 8, 2019 •
edited by DubeySandeep
Loading

Explanation

Fixes #6562: Due to the shutdown of the google plus service, the URL of the oppia google plus account has been removed from the footer in social icons section as well as from the README.md

Checklist

  • The PR title starts with "Fix #bugnum: ", followed by a short, clear summary of the changes. (If this PR fixes part of an issue, prefix the title with "Fix part of #bugnum: ...".)
  • The PR explanation includes the words "Fixes #bugnum: ..." (or "Fixes part of #bugnum" if the PR only partially fixes an issue).
  • The linter/Karma presubmit checks have passed.
    • These should run automatically, but if not, you can manually trigger them locally using python scripts/pre_commit_linter.py and bash scripts/run_frontend_tests.sh.
  • The PR is made from a branch that's not called "develop".
  • The PR follows the style guide.
  • The PR is assigned to an appropriate reviewer.
    • If you're a new contributor, please ask on Gitter for someone to assign a reviewer.
    • If you're not sure who the appropriate reviewer is, please assign to the issue's "owner" -- see the "talk-to" label on the issue.

@ShubhamBansal1997
fix: Removed the google plus from the footer
a7452db 
google plus service is shut down from April 2, 2019
@ShubhamBansal1997
fix: Removed the google plus from Readme.md
0467150 
google plus service is shut down from April 2, 2019
@codecov-io
Copy link

Codecov Report

Merging #6569 into develop will increase coverage by <.01%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff             @@
##           develop    #6569      +/-   ##
===========================================
+ Coverage    75.88%   75.89%   +<.01%     
===========================================
  Files          997      997              
  Lines        79040    79039       -1     
  Branches      4690     4689       -1     
===========================================
+ Hits         59982    59983       +1     
+ Misses       19058    19056       -2
Impacted Files Coverage Δ
core/controllers/skill_editor.py 91.22% <0%> (ø) ⬆️
core/controllers/topic_editor.py 80.87% <0%> (ø) ⬆️
core/domain/interaction_registry.py 100% <0%> (ø) ⬆️
core/controllers/editor.py 80.68% <0%> (ø) ⬆️
core/controllers/creator_dashboard.py 81.37% <0%> (ø) ⬆️
feconf.py 99.45% <0%> (ø) ⬆️
...es/state_editor/StateInteractionEditorDirective.js 34.96% <0%> (+0.42%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f314eb1...0467150. Read the comment docs.

@ShubhamBansal1997
Copy link
Contributor Author

@vojtechjelinek Please review this.

@vojtechjelinek vojtechjelinek self-requested a review April 8, 2019 21:12
vojtechjelinek
vojtechjelinek approved these changes Apr 8, 2019
View reviewed changes
Copy link
Contributor

@vojtechjelinek vojtechjelinek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Could you please share a screenshot of the footer (how it looks without G+ icon)?

@ShubhamBansal1997
Copy link
Contributor Author

Screenshot 2019-04-09 at 2 57 37 AM
@vojtechjelinek

@vojtechjelinek
Copy link
Contributor

Ok, looks good!

@ankita240796 Code owner review, please.

ankita240796
ankita240796 approved these changes Apr 9, 2019
View reviewed changes
Copy link
Contributor

@ankita240796 ankita240796 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, Thanks @ShubhamBansal1997!

@ankita240796 ankita240796 mentioned this pull request Apr 9, 2019
Closed
6 tasks
@DubeySandeep DubeySandeep changed the title Fix #6562 G+ removed from the footer and Readme.md Fix #6562: Removed G+ from the footer and Readme.md Apr 9, 2019
@DubeySandeep DubeySandeep merged commit 26891d8 into oppia:develop Apr 9, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ankita240796 ankita240796 ankita240796 approved these changes

@vojtechjelinek vojtechjelinek vojtechjelinek approved these changes

Assignees

@ankita240796 ankita240796

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Remove G+ icon from footer
5 participants
@ShubhamBansal1997 @codecov-io @vojtechjelinek @ankita240796 @DubeySandeep