Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix #6494: Added check for style properties to have a space between the colon and the property value. #6516

Merged
merged 1 commit into from
Apr 1, 2019
Merged

Fix #6494: Added check for style properties to have a space between the colon and the property value. #6516

merged 1 commit into from
Apr 1, 2019

Conversation

rafalk342
Copy link
Contributor

@rafalk342 rafalk342 commented Mar 27, 2019 •
edited by YashJipkate
Loading

Fixes #6494: Add check for style properties to have a space between the colon and the property value.

I added rules declaration-colon-space-before and declaration-colon-space-after according to https://stylelint.io/user-guide/rules/declaration-colon-space-before/ and https://stylelint.io/user-guide/rules/declaration-colon-space-after/.

Apart from that I ran the check on all html files in ./extensions and ./core and also for oppia.css.

Checklist

  • The PR title starts with "Fix #bugnum: ", followed by a short, clear summary of the changes. (If this PR fixes part of an issue, prefix the title with "Fix part of #bugnum: ...".)
  • The PR explanation includes the words "Fixes #bugnum: ..." (or "Fixes part of #bugnum" if the PR only partially fixes an issue).
  • The linter/Karma presubmit checks have passed.
    • These should run automatically, but if not, you can manually trigger them locally using python scripts/pre_commit_linter.py and bash scripts/run_frontend_tests.sh.
  • The PR is made from a branch that's not called "develop".
  • The PR follows the style guide.
  • The PR is assigned to an appropriate reviewer.
    • If you're a new contributor, please ask on Gitter for someone to assign a reviewer.
    • If you're not sure who the appropriate reviewer is, please assign to the issue's "owner" -- see the "talk-to" label on the issue.

@codecov-io
Copy link

codecov-io commented Mar 27, 2019 •
edited
Loading

Codecov Report

Merging #6516 into develop will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff            @@
##           develop    #6516   +/-   ##
========================================
  Coverage    75.76%   75.76%           
========================================
  Files          992      992           
  Lines        78591    78591           
  Branches      4644     4644           
========================================
  Hits         59546    59546           
  Misses       19045    19045

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6bb95e7...3efce6c. Read the comment docs.

YashJipkate
YashJipkate approved these changes Mar 27, 2019
View reviewed changes
Copy link
Contributor

@YashJipkate YashJipkate left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks, @rafalk342!

ankita240796
ankita240796 reviewed Mar 27, 2019
View reviewed changes
Copy link
Contributor

@ankita240796 ankita240796 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, Thanks @rafalk342!

@seanlip seanlip removed their request for review March 28, 2019 00:03
aks681
aks681 approved these changes Mar 31, 2019
View reviewed changes
Copy link
Contributor

@aks681 aks681 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

nithusha21
nithusha21 approved these changes Apr 1, 2019
View reviewed changes
Copy link
Contributor

@nithusha21 nithusha21 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@nithusha21 nithusha21 merged commit 1f06a25 into oppia:develop Apr 1, 2019
@rafalk342 rafalk342 deleted the check-declaration-space branch July 10, 2019 10:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@YashJipkate YashJipkate YashJipkate approved these changes

@aks681 aks681 aks681 approved these changes

@ankita240796 ankita240796 ankita240796 approved these changes

@nithusha21 nithusha21 nithusha21 approved these changes

@apb7 apb7 Awaiting requested review from apb7

Assignees

@nithusha21 nithusha21

@ankita240796 ankita240796

@aks681 aks681

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add check for style properties to have a space between the colon and the property value.
6 participants
@rafalk342 @codecov-io @nithusha21 @ankita240796 @aks681 @YashJipkate