Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix frontend tests failing occasionally. #6371

Merged
merged 1 commit into from
Mar 3, 2019
Merged

Fix frontend tests failing occasionally. #6371

merged 1 commit into from
Mar 3, 2019

Conversation

seanlip
Copy link
Member

@seanlip seanlip commented Mar 2, 2019

Explanation

Removes indeterminism in the frontend tests which cause them to fail occasionally.

Checklist

  • The PR title starts with "Fix #bugnum: ", followed by a short, clear summary of the changes. (If this PR fixes part of an issue, prefix the title with "Fix part of #bugnum: ...".)
  • The PR explanation includes the words "Fixes #bugnum: ..." (or "Fixes part of #bugnum" if the PR only partially fixes an issue).
  • The linter/Karma presubmit checks have passed.
  • The PR is made from a branch that's not called "develop".
  • The PR follows the style guide.
  • The PR is assigned to an appropriate reviewer.

apb7
apb7 approved these changes Mar 2, 2019
View reviewed changes
Copy link
Contributor

@apb7 apb7 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks @seanlip!

@codecov-io
Copy link

Codecov Report

Merging #6371 into develop will decrease coverage by <.01%.
The diff coverage is 75%.

Impacted file tree graph

@@             Coverage Diff             @@
##           develop    #6371      +/-   ##
===========================================
- Coverage    75.47%   75.47%   -0.01%     
===========================================
  Files          961      961              
  Lines        78067    78070       +3     
  Branches      4641     4641              
===========================================
+ Hits         58918    58920       +2     
- Misses       19149    19150       +1
Impacted Files Coverage Δ
...templates/dev/head/services/IdGenerationService.js 85.71% <75%> (-14.29%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2812471...14325f1. Read the comment docs.

lilithxxx
lilithxxx approved these changes Mar 2, 2019
View reviewed changes
Copy link
Contributor

@lilithxxx lilithxxx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@seanlip seanlip merged commit a55524c into develop Mar 3, 2019
@seanlip seanlip deleted the fix-frontend-tests branch March 3, 2019 01:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lilithxxx lilithxxx lilithxxx approved these changes

@apb7 apb7 apb7 approved these changes

@ankita240796 ankita240796 Awaiting requested review from ankita240796

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@seanlip @codecov-io @apb7 @lilithxxx