Added topics and skills dashboard e2e tests #6204
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Assigning to @tjiang11 and @nithusha21 for review, since they would be better able to spot any missing tests that would need to be added. (From a code perspective I have no concerns. Thanks @aks681!) |
Codecov Report
@@ Coverage Diff @@
## develop #6204 +/- ##
========================================
Coverage 45.38% 45.38%
========================================
Files 525 525
Lines 30925 30925
Branches 4633 4633
========================================
Hits 14034 14034
Misses 16891 16891Continue to review full report at Codecov.
|
nithusha21
suggested changes
Feb 5, 2019
core/templates/dev/head/components/top_navigation_bar/top_navigation_bar_directive.html
Outdated
Show resolved
Hide resolved
tjiang11
approved these changes
Feb 6, 2019
seanlip
approved these changes
Feb 6, 2019
|
Thanks! Merging. |
6 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In this PR, the preliminary e2e tests related to topics and skills dashboard are done.
More tests related to published skills have to be added once skill editor e2e tests are done by @nalinbhardwaj .
Also, in this PR, the
ENABLE_NEW_STRUCTURE_EDITORSis now flipped.