Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixes #4407 KaTeX text no longer goes outside text container in MathExpressionInput #6130

Merged
merged 3 commits into from
Jan 21, 2019
Merged

Fixes #4407 KaTeX text no longer goes outside text container in MathExpressionInput #6130

merged 3 commits into from
Jan 21, 2019

Conversation

ctao5660
Copy link
Contributor

@ctao5660 ctao5660 commented Jan 17, 2019 •
edited
Loading

Explanation

Fixes #4407, Katex text now overflows correctly.

Checklist

  • The PR title starts with "Fix #bugnum: ", followed by a short, clear summary of the changes. (If this PR fixes part of an issue, prefix the title with "Fix part of #bugnum: ...".)
  • The PR explanation includes the words "Fixes #bugnum: ..." (or "Fixes part of #bugnum" if the PR only partially fixes an issue).
  • The linter/Karma presubmit checks have passed.
    • These should run automatically, but if not, you can manually trigger them locally using python scripts/pre_commit_linter.py and bash scripts/run_frontend_tests.sh.
  • The PR is made from a branch that's not called "develop".
  • The PR follows the style guide.
  • The PR is assigned to an appropriate reviewer.
    • If you're a new contributor, please ask on Gitter for someone to assign a reviewer.
    • If you're not sure who the appropriate reviewer is, please assign to the issue's "owner" -- see the "talk-to" label on the issue.

@codecov-io
Copy link

codecov-io commented Jan 17, 2019 •
edited
Loading

Codecov Report

Merging #6130 into develop will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff            @@
##           develop    #6130   +/-   ##
========================================
  Coverage    45.33%   45.33%           
========================================
  Files          525      525           
  Lines        30862    30862           
  Branches      4615     4615           
========================================
  Hits         13990    13990           
  Misses       16872    16872

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update bfc1c18...393a6b7. Read the comment docs.

@ctao5660 ctao5660 requested a review from vibhor98 January 18, 2019 20:36
vibhor98
vibhor98 suggested changes Jan 19, 2019
View reviewed changes
Copy link
Contributor

@vibhor98 vibhor98 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @ctao5660, thanks for the PR! Took a pass, PTAL!

...interactions/MathExpressionInput/directives/math_expression_input_interaction_directive.html Outdated
@@ -1,5 +1,5 @@
<div class="guppy-div"
style="width: 100%; height: 100px; padding: 5px;">
style="width: 100%; height: 100px; padding: 5px; overflow:auto; word-break: normal; line-break; word-wrap: normal">
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Add space after overflow:. Also, value of line-break is missing?
Add semicolon after word-wrap: normal.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done.

@vibhor98
Copy link
Contributor

Hi @ctao5660, Right now if the text exceeds the text area, the learner has to scroll horizontally in order to see the full KaTeX text. I think it will be better if the cursor automatically goes to next line whenever the cursor comes to the end of the text area. What do you think?

@ctao5660
Copy link
Contributor Author

ctao5660 commented Jan 21, 2019 via email

vibhor98
vibhor98 approved these changes Jan 21, 2019
View reviewed changes
Copy link
Contributor

@vibhor98 vibhor98 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah... I see. Thanks for letting me know. I also agree here!

LGTM, thanks!

@vibhor98 vibhor98 merged commit dd5c2f3 into oppia:develop Jan 21, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vibhor98 vibhor98 vibhor98 approved these changes

@nithusha21 nithusha21 Awaiting requested review from nithusha21

@seanlip seanlip Awaiting requested review from seanlip

Assignees

@ctao5660 ctao5660

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Text inside MathExpressionInput area exceeds the text area.
3 participants
@ctao5660 @codecov-io @vibhor98