Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix #6056: Makes the resize of text box vertical #6057

Merged
merged 2 commits into from
Jan 6, 2019
Merged

Fix #6056: Makes the resize of text box vertical #6057

merged 2 commits into from
Jan 6, 2019

Conversation

mighty-phoenix
Copy link
Contributor

@mighty-phoenix mighty-phoenix commented Jan 5, 2019 •
edited
Loading

Explanation

Fixes #6056: Makes the resize of text box vertical

Checklist

  • The PR title starts with "Fix #bugnum: ", followed by a short, clear summary of the changes. (If this PR fixes part of an issue, prefix the title with "Fix part of #bugnum: ...".)
  • The PR explanation includes the words "Fixes #bugnum: ..." (or "Fixes part of #bugnum" if the PR only partially fixes an issue).
  • The linter/Karma presubmit checks have passed.
    • These should run automatically, but if not, you can manually trigger them locally using python scripts/pre_commit_linter.py and bash scripts/run_frontend_tests.sh.
  • The PR is made from a branch that's not called "develop".
  • The PR follows the style guide.
  • The PR is assigned to an appropriate reviewer.
    • If you're a new contributor, please ask on Gitter for someone to assign a reviewer.
    • If you're not sure who the appropriate reviewer is, please assign to the issue's "owner" -- see the "talk-to" label on the issue.

@codecov-io
Copy link

codecov-io commented Jan 5, 2019 •
edited
Loading

Codecov Report

Merging #6057 into develop will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff            @@
##           develop    #6057   +/-   ##
========================================
  Coverage    45.21%   45.21%           
========================================
  Files          523      523           
  Lines        30722    30722           
  Branches      4605     4605           
========================================
  Hits         13892    13892           
  Misses       16830    16830

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 718d4d0...04a6be6. Read the comment docs.

kevinlee12
kevinlee12 reviewed Jan 5, 2019
View reviewed changes
core/templates/dev/head/pages/exploration_editor/exploration_save_modal_directive.html Outdated
@@ -8,7 +8,7 @@ <h3>
<p>
<span ng-if="isExplorationPrivate">(Optional)</span>
Please enter a brief description of what you have changed:
<textarea rows="3" cols="50" ng-model="commitMessage" focus-on="saveChangesModalOpened" class="protractor-test-commit-message-input" autofocus></textarea>
<textarea rows="3" cols="50" style="resize: vertical;" ng-model="commitMessage" focus-on="saveChangesModalOpened" class="protractor-test-commit-message-input" autofocus></textarea>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Remove the semicolon at the end of vertical

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the review! @kevinlee12 😃 Made the change. PTAL!

@kevinlee12
Copy link
Contributor

UI-wise, it looks great! 😄

@mighty-phoenix
Copy link
Contributor Author

@kevinlee12 Thanks for the review 😄
Made the change suggested. PTAL and merge.

kevinlee12
kevinlee12 reviewed Jan 5, 2019
View reviewed changes
Copy link
Contributor

@kevinlee12 kevinlee12 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, thanks @rakshitkumarcse!

kevinlee12
kevinlee12 approved these changes Jan 6, 2019
View reviewed changes
Copy link
Contributor

@kevinlee12 kevinlee12 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm! (apparently forgot to tell Github that I ok-ed it)

@kevinlee12 kevinlee12 merged commit cd22391 into oppia:develop Jan 6, 2019
@mighty-phoenix
Copy link
Contributor Author

@kevinlee12
Thanks 😊

seanlip pushed a commit that referenced this pull request Jan 11, 2019
@mighty-phoenix @seanlip
Fix #6056: Makes the resize of text box vertical (#6057)
c93200d 
* Fix #6056: Makes the resize of text box vertical

* Correction
@seanlip
Copy link
Member

seanlip commented Jan 14, 2019 •
edited
Loading

Hi @rakshitkumarcse @kevinlee12, just wanted to leave a note FYI: I'm currently working on compiling the release and finalizing the changelog, and I found the title of this PR particularly hard to understand. With the existing title, I have no idea what "text box" refers to and what making its resizing "vertical" means. A better title would have been something like: "Fix #6056: Prevent the text box in the Save Draft modal from flowing out of the modal boundaries."

Just wanted to leave a note for the future -- it's important to make sure your PR titles are self-contained and understandable, so that they can be easily compiled and classified for the release. Any contributor should be able to tell what the PR is doing just based on its title alone, without needing to look through its details.

Thanks!

@mighty-phoenix
Copy link
Contributor Author

Hi @seanlip. Sorry for the inconvenience.
Will make sure this doesn't happen again.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kevinlee12 kevinlee12 kevinlee12 approved these changes

@nithusha21 nithusha21 Awaiting requested review from nithusha21

Assignees

@kevinlee12 kevinlee12

Labels
PR: LGTM
Projects
None yet
Milestone
No milestone
6 participants
@mighty-phoenix @codecov-io @kevinlee12 @seanlip @nithusha21 @vibhor98