Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix #5978: Stewards page content alignment. #6042

Merged
merged 1 commit into from
Jan 2, 2019
Merged

Fix #5978: Stewards page content alignment. #6042

merged 1 commit into from
Jan 2, 2019

Conversation

DubeySandeep
Copy link
Member

Explanation

Fixes #5978: Stewards page content alignment.

Checklist

  • The PR title starts with "Fix #bugnum: ", followed by a short, clear summary of the changes. (If this PR fixes part of an issue, prefix the title with "Fix part of #bugnum: ...".)
  • The PR explanation includes the words "Fixes #bugnum: ..." (or "Fixes part of #bugnum" if the PR only partially fixes an issue).
  • The linter/Karma presubmit checks have passed.
    • These should run automatically, but if not, you can manually trigger them locally using python scripts/pre_commit_linter.py and bash scripts/run_frontend_tests.sh.
  • The PR is made from a branch that's not called "develop".
  • The PR follows the style guide.
  • The PR is assigned to an appropriate reviewer.
    • If you're a new contributor, please ask on Gitter for someone to assign a reviewer.
    • If you're not sure who the appropriate reviewer is, please assign to the issue's "owner" -- see the "talk-to" label on the issue.

@DubeySandeep DubeySandeep requested a review from vibhor98 January 2, 2019 09:32
@codecov-io
Copy link

Codecov Report

Merging #6042 into develop will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff            @@
##           develop    #6042   +/-   ##
========================================
  Coverage    45.21%   45.21%           
========================================
  Files          523      523           
  Lines        30722    30722           
  Branches      4605     4605           
========================================
  Hits         13892    13892           
  Misses       16830    16830

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 75fb742...01f53d5. Read the comment docs.

@vibhor98
Copy link
Contributor

vibhor98 commented Jan 2, 2019 •
edited
Loading

Hi @DubeySandeep, thanks for filing the PR! Can you add link here where I can reproduce this issue? Thanks!

vibhor98
vibhor98 approved these changes Jan 2, 2019
View reviewed changes
Copy link
Contributor

@vibhor98 vibhor98 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks @DubeySandeep! I found the page here. Thanks!

@nithusha21 nithusha21 merged commit f8b0216 into oppia:develop Jan 2, 2019
abhaygupta97 pushed a commit to abhaygupta97/oppia that referenced this pull request Jan 2, 2019
@DubeySandeep @abhaygupta97
Changes in style as asked in issue. (oppia#6042)
5a43480
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vibhor98 vibhor98 vibhor98 approved these changes

Assignees

@vibhor98 vibhor98

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

centralise content on the Oppia landing page
5 participants
@DubeySandeep @codecov-io @vibhor98 @seanlip @nithusha21