Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix part of #4374: Add docstrings to the Python files. #6041

Merged
merged 4 commits into from
Jan 4, 2019
Merged

Fix part of #4374: Add docstrings to the Python files. #6041

merged 4 commits into from
Jan 4, 2019

Conversation

vibhor98
Copy link
Contributor

@vibhor98 vibhor98 commented Dec 31, 2018 •
edited
Loading

Explanation

Checklist

  • The PR title starts with "Fix #bugnum: ", followed by a short, clear summary of the changes. (If this PR fixes part of an issue, prefix the title with "Fix part of #bugnum: ...".)
  • The PR explanation includes the words "Fixes #bugnum: ..." (or "Fixes part of #bugnum" if the PR only partially fixes an issue).
  • The linter/Karma presubmit checks have passed.
    • These should run automatically, but if not, you can manually trigger them locally using python scripts/pre_commit_linter.py and bash scripts/run_frontend_tests.sh.
  • The PR is made from a branch that's not called "develop".
  • The PR follows the style guide.
  • The PR is assigned to an appropriate reviewer.
    • If you're a new contributor, please ask on Gitter for someone to assign a reviewer.
    • If you're not sure who the appropriate reviewer is, please assign to the issue's "owner" -- see the "talk-to" label on the issue.

@vibhor98 vibhor98 requested a review from nithusha21 December 31, 2018 20:38
@codecov-io
Copy link

codecov-io commented Dec 31, 2018 •
edited
Loading

Codecov Report

Merging #6041 into develop will decrease coverage by 0.05%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff             @@
##           develop    #6041      +/-   ##
===========================================
- Coverage    45.27%   45.21%   -0.06%     
===========================================
  Files          521      523       +2     
  Lines        30688    30722      +34     
  Branches      4597     4605       +8     
===========================================
- Hits         13894    13892       -2     
- Misses       16794    16830      +36
Impacted Files Coverage Δ
...dev/head/pages/exploration_editor/RouterService.js 17.5% <0%> (-5.31%) ⬇️
...head/pages/exploration_editor/ExplorationEditor.js 5.12% <0%> (-0.11%) ⬇️
...es/exploration_editor/EditorNavigationDirective.js 2.08% <0%> (-0.1%) ⬇️
...ges/exploration_editor/settings_tab/SettingsTab.js 0.62% <0%> (ø) ⬆️
...ad/pages/skill_editor/SkillEditorRoutingService.js 4% <0%> (ø) ⬆️
...s/exploration_editor/ExplorationWarningsService.js 11.34% <0%> (ø) ⬆️
...loration_editor/EditorNavbarBreadcrumbDirective.js 5.55% <0%> (ø) ⬆️
...ad/pages/topic_editor/TopicEditorRoutingService.js 3.33% <0%> (ø) ⬆️
...ditor/CollectionEditorNavbarBreadcrumbDirective.js 9.09% <0%> (ø) ⬆️
...r/editor_tab/UnresolvedAnswersOverviewDirective.js 1.13% <0%> (ø) ⬆️
... and 6 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ba37cc9...e25ac98. Read the comment docs.

nithusha21
nithusha21 suggested changes Jan 2, 2019
View reviewed changes
Copy link
Contributor

@nithusha21 nithusha21 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi Vibhor! Thanks for the PR. Here is my first pass

core/controllers/admin.py Outdated Show resolved Hide resolved
core/controllers/admin.py Outdated Show resolved Hide resolved
core/controllers/base_test.py Outdated Show resolved Hide resolved
core/controllers/creator_dashboard.py Outdated Show resolved Hide resolved
core/controllers/creator_dashboard.py Outdated Show resolved Hide resolved
core/controllers/skill_editor_test.py Outdated Show resolved Hide resolved
core/platform/search/gae_search_services.py Outdated Show resolved Hide resolved
core/platform/search/gae_search_services.py Show resolved Hide resolved
core/platform/search/gae_search_services.py Outdated Show resolved Hide resolved
core/platform/search/gae_search_services.py Outdated Show resolved Hide resolved
nithusha21
nithusha21 reviewed Jan 3, 2019
View reviewed changes
Copy link
Contributor

@nithusha21 nithusha21 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @vibhor98 thanks for the changes. A few more comments

core/controllers/feedback_test.py Outdated Show resolved Hide resolved
core/controllers/admin.py Outdated Show resolved Hide resolved
core/controllers/admin.py Outdated Show resolved Hide resolved
core/controllers/reader_test.py Outdated Show resolved Hide resolved
core/controllers/reader_test.py Outdated Show resolved Hide resolved
core/controllers/reader_test.py Outdated Show resolved Hide resolved
core/controllers/reader_test.py Outdated Show resolved Hide resolved
core/platform/search/gae_search_services.py Outdated Show resolved Hide resolved
core/platform/search/gae_search_services.py Outdated Show resolved Hide resolved
@nithusha21 nithusha21 assigned vibhor98 and unassigned nithusha21 Jan 3, 2019
nithusha21
nithusha21 approved these changes Jan 4, 2019
View reviewed changes
Copy link
Contributor

@nithusha21 nithusha21 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this looks good. Thanks @vibhor98!

@vibhor98
Copy link
Contributor Author

vibhor98 commented Jan 4, 2019

Thanks @nithusha21! Merging...

@vibhor98 vibhor98 merged commit d2a7fc3 into oppia:develop Jan 4, 2019
@vibhor98 vibhor98 deleted the add-dstrings branch January 4, 2019 13:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nithusha21 nithusha21 nithusha21 approved these changes

Assignees

@vibhor98 vibhor98

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@vibhor98 @codecov-io @nithusha21