Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix part of #4374: Add docstrings to the Python files #6035

Merged
merged 1 commit into from
Dec 28, 2018
Merged

Fix part of #4374: Add docstrings to the Python files #6035

merged 1 commit into from
Dec 28, 2018

Conversation

vibhor98
Copy link
Contributor

@vibhor98 vibhor98 commented Dec 28, 2018 •
edited
Loading

Explanation

Checklist

  • The PR title starts with "Fix #bugnum: ", followed by a short, clear summary of the changes. (If this PR fixes part of an issue, prefix the title with "Fix part of #bugnum: ...".)
  • The PR explanation includes the words "Fixes #bugnum: ..." (or "Fixes part of #bugnum" if the PR only partially fixes an issue).
  • The linter/Karma presubmit checks have passed.
    • These should run automatically, but if not, you can manually trigger them locally using python scripts/pre_commit_linter.py and bash scripts/run_frontend_tests.sh.
  • The PR is made from a branch that's not called "develop".
  • The PR follows the style guide.
  • The PR is assigned to an appropriate reviewer.
    • If you're a new contributor, please ask on Gitter for someone to assign a reviewer.
    • If you're not sure who the appropriate reviewer is, please assign to the issue's "owner" -- see the "talk-to" label on the issue.

@vibhor98 vibhor98 requested a review from nithusha21 December 28, 2018 10:39
nithusha21
nithusha21 approved these changes Dec 28, 2018
View reviewed changes
Copy link
Contributor

@nithusha21 nithusha21 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM Thanks @vibhor98

@codecov-io
Copy link

Codecov Report

Merging #6035 into develop will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           develop   #6035   +/-   ##
=======================================
  Coverage     45.3%   45.3%           
=======================================
  Files          520     520           
  Lines        30667   30667           
  Branches      4597    4597           
=======================================
  Hits         13893   13893           
  Misses       16774   16774

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e6a1c2a...36dac20. Read the comment docs.

@vibhor98
Copy link
Contributor Author

Thanks @nithusha21 for approval! Merging...

@vibhor98 vibhor98 merged commit ff94f82 into oppia:develop Dec 28, 2018
@vibhor98 vibhor98 deleted the add-dstrings branch December 28, 2018 17:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nithusha21 nithusha21 nithusha21 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@vibhor98 @codecov-io @nithusha21