Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix part of #4374: Adds docstring in core/domain/exp_services_test.py #6027

Merged
merged 2 commits into from
Dec 25, 2018
Merged

Fix part of #4374: Adds docstring in core/domain/exp_services_test.py #6027

merged 2 commits into from
Dec 25, 2018

Conversation

dev-ritik
Copy link
Contributor

@dev-ritik dev-ritik commented Dec 24, 2018 •
edited
Loading

Explanation

Fix part of #4374: Adds docstring in core/domain/exp_services_test.py

Checklist

  • The PR title starts with "Fix #bugnum: ", followed by a short, clear summary of the changes. (If this PR fixes part of an issue, prefix the title with "Fix part of #bugnum: ...".)
  • The PR explanation includes the words "Fixes #bugnum: ..." (or "Fixes part of #bugnum" if the PR only partially fixes an issue).
  • The linter/Karma presubmit checks have passed.
    • These should run automatically, but if not, you can manually trigger them locally using python scripts/pre_commit_linter.py and bash scripts/run_frontend_tests.sh.
  • The PR is assigned to an appropriate reviewer.
    • If you're a new contributor, please ask on Gitter for someone to assign a reviewer.
    • If you're not sure who the appropriate reviewer is, please assign to the issue's "owner" -- see the "talk-to" label on the issue.
  • The PR is made from a branch that's not called "develop".
  • The PR follows the style guide.

@vibhor98 vibhor98 self-assigned this Dec 24, 2018
vibhor98
vibhor98 suggested changes Dec 24, 2018
View reviewed changes
Copy link
Contributor

@vibhor98 vibhor98 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @dev-ritik, thanks for the PR! Took a pass, PTAL!

core/domain/exp_services_test.py Outdated Show resolved Hide resolved
core/domain/exp_services_test.py Show resolved Hide resolved
core/domain/exp_services_test.py Outdated Show resolved Hide resolved
core/domain/exp_services_test.py Outdated Show resolved Hide resolved
@codecov-io
Copy link

codecov-io commented Dec 24, 2018 •
edited
Loading

Codecov Report

Merging #6027 into develop will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           develop   #6027   +/-   ##
=======================================
  Coverage     45.3%   45.3%           
=======================================
  Files          520     520           
  Lines        30667   30667           
  Branches      4597    4597           
=======================================
  Hits         13893   13893           
  Misses       16774   16774

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ef0bd13...b12c0da. Read the comment docs.

@DubeySandeep DubeySandeep assigned dev-ritik and unassigned vibhor98 Dec 24, 2018
@ankita240796
Copy link
Contributor

Hi @dev-ritik, can you please update the PR title to Fix part of #4374: Adds docstring in core/domain/exp_services_test.py

@dev-ritik dev-ritik changed the title Add docstring in core/domain/exp_services_test.py Fix part of #4374: Adds docstring in core/domain/exp_services_test.py Dec 24, 2018
vibhor98
vibhor98 approved these changes Dec 25, 2018
View reviewed changes
Copy link
Contributor

@vibhor98 vibhor98 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks @dev-ritik! 😄

@vibhor98
Copy link
Contributor

Congrats on your first PR!

@vibhor98 vibhor98 merged commit a0e721c into oppia:develop Dec 25, 2018
@dev-ritik dev-ritik deleted the doc_string branch December 25, 2018 19:25
@dev-ritik
Copy link
Contributor Author

Thanks @vibhor98!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vibhor98 vibhor98 vibhor98 approved these changes

Assignees

@dev-ritik dev-ritik

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@dev-ritik @codecov-io @ankita240796 @vibhor98