Add try..except block in pre-commit linter #6019

apb7 · 2018-12-21T08:23:38Z

Add try..except block to handle the case when
there are no Python, JavaScript or CSS files to lint.

Explanation

Checklist

The PR title starts with "Fix #bugnum: ", followed by a short, clear summary of the changes. (If this PR fixes part of an issue, prefix the title with "Fix part of #bugnum: ...".)
The PR explanation includes the words "Fixes #bugnum: ..." (or "Fixes part of #bugnum" if the PR only partially fixes an issue).
The linter/Karma presubmit checks have passed.
- These should run automatically, but if not, you can manually trigger them locally using python scripts/pre_commit_linter.py and bash scripts/run_frontend_tests.sh.
The PR is made from a branch that's not called "develop".
The PR follows the style guide.
The PR is assigned to an appropriate reviewer.
- If you're a new contributor, please ask on Gitter for someone to assign a reviewer.
- If you're not sure who the appropriate reviewer is, please assign to the issue's "owner" -- see the "talk-to" label on the issue.

Add try..except block to handle the case when there are no Python, JavaScript or CSS files to lint.

DubeySandeep · 2018-12-21T09:15:07Z

scripts/pre_commit_linter.py

-            TIMEOUT_MULTIPLIER * len(file_group) / number_of_files_to_lint))
+
+        # try..except block is needed to catch ZeroDivisionError
+        # when there are no Python, JavaScript or CSS files to lint.


We also count HTML files, right?

Um, yes, we include the HTML files to check for the CSS part. Let me modify the comment here then. Thanks!

codecov-io · 2018-12-21T09:37:31Z

Codecov Report

Merging #6019 into develop will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           develop   #6019   +/-   ##
=======================================
  Coverage     45.3%   45.3%           
=======================================
  Files          520     520           
  Lines        30667   30667           
  Branches      4597    4597           
=======================================
  Hits         13893   13893           
  Misses       16774   16774

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d101331...ee66f00. Read the comment docs.

nithusha21 · 2018-12-21T09:41:27Z

scripts/pre_commit_linter.py

@@ -739,8 +739,14 @@ def _pre_commit_linter(all_files):
    for file_group, process in zip(file_groups_to_lint, linting_processes):
        # Require timeout parameter to prevent against endless waiting for the


Probably move this comment inside the try block?

Done, thanks!

apb7 · 2018-12-21T11:33:04Z

Thanks, @nithusha21! Hi @BenHenning, can you please approve this as a code owner? Thanks!

Add try..except block in pre-commit linter

11ad36d

Add try..except block to handle the case when there are no Python, JavaScript or CSS files to lint.

apb7 assigned nithusha21 Dec 21, 2018

apb7 requested a review from nithusha21 December 21, 2018 08:23

apb7 requested review from BenHenning and seanlip as code owners December 21, 2018 08:23

DubeySandeep reviewed Dec 21, 2018

View reviewed changes

Modify comment

c5d3735

nithusha21 reviewed Dec 21, 2018

View reviewed changes

Move comment inside the try..except block

ee66f00

nithusha21 approved these changes Dec 21, 2018

View reviewed changes

nithusha21 merged commit 8a58279 into oppia:develop Dec 21, 2018

apb7 deleted the add-check-for-no-files-to-lint branch December 21, 2018 16:32

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Add try..except block in pre-commit linter #6019

Add try..except block in pre-commit linter #6019

apb7 commented Dec 21, 2018

DubeySandeep Dec 21, 2018

apb7 Dec 21, 2018

codecov-io commented Dec 21, 2018 •

edited

Loading

nithusha21 Dec 21, 2018

apb7 Dec 21, 2018

apb7 commented Dec 21, 2018

		@@ -739,8 +739,14 @@ def _pre_commit_linter(all_files):
		for file_group, process in zip(file_groups_to_lint, linting_processes):
		# Require timeout parameter to prevent against endless waiting for the

Add try..except block in pre-commit linter #6019

Add try..except block in pre-commit linter #6019

Conversation

apb7 commented Dec 21, 2018

Explanation

Checklist

DubeySandeep Dec 21, 2018

Choose a reason for hiding this comment

apb7 Dec 21, 2018

Choose a reason for hiding this comment

codecov-io commented Dec 21, 2018 • edited Loading

Codecov Report

nithusha21 Dec 21, 2018

Choose a reason for hiding this comment

apb7 Dec 21, 2018

Choose a reason for hiding this comment

apb7 commented Dec 21, 2018

codecov-io commented Dec 21, 2018 •

edited

Loading