Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix #4968: Move customization args method from state_domain to customization_args_util #6015

Merged
merged 9 commits into from
Dec 21, 2018
Merged

Fix #4968: Move customization args method from state_domain to customization_args_util #6015

merged 9 commits into from
Dec 21, 2018

Conversation

ankita240796
Copy link
Contributor

@ankita240796 ankita240796 commented Dec 20, 2018 •
edited by brianrodri
Loading

Explanation

Fixes #4968:

  • Moved get_full_customization_args and validate_customization_args_and_values from state_domain.py to customization_args_util.py.
  • Added test for both these methods.

@ankita240796 ankita240796 mentioned this pull request Dec 20, 2018
Closed
@apb7 apb7 requested a review from brianrodri December 20, 2018 14:32
@codecov-io
Copy link

codecov-io commented Dec 20, 2018 •
edited
Loading

Codecov Report

Merging #6015 into develop will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           develop   #6015   +/-   ##
=======================================
  Coverage     45.3%   45.3%           
=======================================
  Files          520     520           
  Lines        30667   30667           
  Branches      4597    4597           
=======================================
  Hits         13893   13893           
  Misses       16774   16774

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8a58279...87887ce. Read the comment docs.

brianrodri
brianrodri suggested changes Dec 21, 2018
View reviewed changes
utils.py Outdated Show resolved Hide resolved
brianrodri
brianrodri suggested changes Dec 21, 2018
View reviewed changes
Copy link
Contributor

@brianrodri brianrodri left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @ankita240796! Please try to give the variables more meaningful names, I added some examples for your reference.

schema_utils_test.py Outdated Show resolved Hide resolved
schema_utils_test.py Outdated Show resolved Hide resolved
schema_utils_test.py Outdated Show resolved Hide resolved
schema_utils_test.py Outdated Show resolved Hide resolved
schema_utils.py Outdated Show resolved Hide resolved
@ankita240796
Copy link
Contributor Author

Hi @brianrodri, I have made the suggested changes, PTAL!

@ankita240796 ankita240796 force-pushed the move-customizationArgs-func branch from a5f0d56 to 87887ce Compare December 21, 2018 18:44
brianrodri
brianrodri approved these changes Dec 21, 2018
View reviewed changes
Copy link
Contributor

@brianrodri brianrodri left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great, thanks so much @ankita240796!

@brianrodri brianrodri changed the title Fix #4968: Move customization args method from state_domain to utils Fix #4968: Move customization args method from state_domain to customization_args_util Dec 21, 2018
@brianrodri brianrodri merged commit a5aaaf6 into oppia:develop Dec 21, 2018
@ankita240796 ankita240796 deleted the move-customizationArgs-func branch December 22, 2018 04:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@brianrodri brianrodri brianrodri approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ankita240796 @codecov-io @brianrodri