Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixes part of #4374: Add docstring in core/domain/feedback_jobs_continuous.py #6006

Merged
merged 3 commits into from
Dec 24, 2018
Merged

Fixes part of #4374: Add docstring in core/domain/feedback_jobs_continuous.py #6006

merged 3 commits into from
Dec 24, 2018

Conversation

vddesai1871
Copy link
Contributor

@vddesai1871 vddesai1871 commented Dec 19, 2018 •
edited
Loading

Explanation

Fixes part of #4374: Adds docstring in core/domain/feedback_jobs_continuous.py (particularly in nested funcions)

Checklist

  • The PR title starts with "Fix #bugnum: ", followed by a short, clear summary of the changes. (If this PR fixes part of an issue, prefix the title with "Fix part of #bugnum: ...".)
  • The PR explanation includes the words "Fixes #bugnum: ..." (or "Fixes part of #bugnum" if the PR only partially fixes an issue).
  • The linter/Karma presubmit checks have passed.
    • These should run automatically, but if not, you can manually trigger them locally using python scripts/pre_commit_linter.py and bash scripts/run_frontend_tests.sh.
  • The PR is made from a branch that's not called "develop".
  • The PR follows the style guide.
  • The PR is assigned to an appropriate reviewer.
    • If you're a new contributor, please ask on Gitter for someone to assign a reviewer.
    • If you're not sure who the appropriate reviewer is, please assign to the issue's "owner" -- see the "talk-to" label on the issue.

@codecov-io
Copy link

codecov-io commented Dec 19, 2018 •
edited
Loading

Codecov Report

Merging #6006 into develop will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           develop   #6006   +/-   ##
=======================================
  Coverage     45.3%   45.3%           
=======================================
  Files          520     520           
  Lines        30667   30667           
  Branches      4597    4597           
=======================================
  Hits         13893   13893           
  Misses       16774   16774
Impacted Files Coverage Δ
...xploration_player/ExplorationPlayerStateService.js 1.53% <0%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 85057a7...60a8c84. Read the comment docs.

@DubeySandeep
Copy link
Member

H @vddesai1871, I think you haven't signed the CLA yet. Please follow the steps provided in the wiki page to get started. I'm closing this PR for now, you can re-open it once you are done with signing CLA and filling up the survey form. Thanks! :)

@vddesai1871
Copy link
Contributor Author

vddesai1871 commented Dec 20, 2018 •
edited
Loading

Hii @DubeySandeep , I had filled signed CLA. But I have changed my username since then and now I am getting "You've already responded, you can fill out the form only once" message on the form. How can I sign it again?

@vddesai1871 vddesai1871 mentioned this pull request Dec 21, 2018
Closed
@DubeySandeep DubeySandeep reopened this Dec 21, 2018
@DubeySandeep DubeySandeep self-requested a review December 21, 2018 06:01
@DubeySandeep DubeySandeep self-assigned this Dec 21, 2018
DubeySandeep
DubeySandeep reviewed Dec 21, 2018
View reviewed changes
Copy link
Member

@DubeySandeep DubeySandeep left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @vddesai1871, Thanks for the PR, changes look good to me, can you please add docstring on line 220 and 224?

DubeySandeep
DubeySandeep approved these changes Dec 24, 2018
View reviewed changes
Copy link
Member

@DubeySandeep DubeySandeep left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@vddesai1871, Thanks for the changes, PR LGTM! :)

@DubeySandeep DubeySandeep merged commit ef0bd13 into oppia:develop Dec 24, 2018
@DubeySandeep
Copy link
Member

DubeySandeep commented Dec 24, 2018 •
edited
Loading

@vddesai1871, Congrats on your first successful PR to Oppia! :D

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@DubeySandeep DubeySandeep DubeySandeep approved these changes

Assignees

@vddesai1871 vddesai1871

Labels
PR: LGTM
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@vddesai1871 @codecov-io @DubeySandeep