Fixes #5529: Print python lint errors at the end of the check #6005
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## develop #6005 +/- ##
=======================================
Coverage 45.3% 45.3%
=======================================
Files 520 520
Lines 30667 30667
Branches 4597 4597
=======================================
Hits 13893 13893
Misses 16774 16774
Continue to review full report at Codecov.
|
kevinlee12
approved these changes
Dec 22, 2018
There was a problem hiding this comment.
lgtm!
sending this to @seanlip and @BenHenning for code owner review.
nithusha21
approved these changes
Dec 22, 2018
| pycodestyle_report = style_guide.check_files( | ||
| paths=current_files_to_lint) | ||
| # This line prints Pycodestyle's output to the console. | ||
| pycodestyle_report.print_statistics() |
There was a problem hiding this comment.
This line seems to be missing below. Is this intentional?
|
Yes, we do not need that line now. I had earlier placed it thinking that it
prints the errors but just invoking pycodestyle in the line above prints
the errors. Thanks!
…On Sat, Dec 22, 2018, 9:46 AM Nithesh N. Hariharan ***@***.***> wrote:
***@***.**** approved this pull request.
LGTM. Just one confirmation.
------------------------------
In scripts/pre_commit_linter.py
<#6005 (comment)>:
> @@ -524,18 +536,21 @@ def _lint_py_files(config_pylint, config_pycodestyle, files_to_lint, result):
print 'Linting Python files %s to %s...' % (
current_batch_start_index + 1, current_batch_end_index)
- # This line invokes Pylint and prints its output to the console.
- pylinter = lint.Run(
- current_files_to_lint + [config_pylint],
- exit=False).linter
- # These lines invoke Pycodestyle.
- style_guide = pycodestyle.StyleGuide(config_file=config_pycodestyle)
- pycodestyle_report = style_guide.check_files(
- paths=current_files_to_lint)
- # This line prints Pycodestyle's output to the console.
- pycodestyle_report.print_statistics()
This line seems to be missing below. Is this intentional?
—
You are receiving this because you were assigned.
Reply to this email directly, view it on GitHub
<#6005 (review)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AXrQuedDFPndloTPEJ1v_Z6ML2cFJyvuks5u7bILgaJpZM4Zaclp>
.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Explanation
Fixes #5529.
Redirects the output from stdout to a temporary stream using context manager as suggested by @seanlip here. This stream is later used to retrieve the output and put in
resultqueue.Checklist
python scripts/pre_commit_linter.pyandbash scripts/run_frontend_tests.sh.