Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix false positive travis build #6002

Merged
merged 4 commits into from
Dec 19, 2018
Merged

Fix false positive travis build #6002

merged 4 commits into from
Dec 19, 2018

Conversation

nithusha21
Copy link
Contributor

Explanation

Supersedes #5995. Thanks @apb7 for the fix. Redoing the PR for codeowner approval!

Checklist

  • The PR title starts with "Fix #bugnum: ", followed by a short, clear summary of the changes. (If this PR fixes part of an issue, prefix the title with "Fix part of #bugnum: ...".)
  • The PR explanation includes the words "Fixes #bugnum: ..." (or "Fixes part of #bugnum" if the PR only partially fixes an issue).
  • The linter/Karma presubmit checks have passed.
    • These should run automatically, but if not, you can manually trigger them locally using python scripts/pre_commit_linter.py and bash scripts/run_frontend_tests.sh.
  • The PR is made from a branch that's not called "develop".
  • The PR follows the style guide.
  • The PR is assigned to an appropriate reviewer.
    • If you're a new contributor, please ask on Gitter for someone to assign a reviewer.
    • If you're not sure who the appropriate reviewer is, please assign to the issue's "owner" -- see the "talk-to" label on the issue.

apb7 added 4 commits December 17, 2018 19:51
@apb7
Fixes false positive builds on Travis.
44ac23e 
This increases the timeout of the thread so that there is
sufficient time for summary messages to be put in the result queue.
@apb7
Add timeout proportionatal to the number of files to lint
2e8328c
@apb7
Set proportion for timeout
1f48a30
@apb7
Add timeout multiplier
8333da1
@nithusha21 nithusha21 requested a review from apb7 December 18, 2018 06:41
@codecov-io
Copy link

Codecov Report

Merging #6002 into develop will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           develop   #6002   +/-   ##
=======================================
  Coverage     45.3%   45.3%           
=======================================
  Files          520     520           
  Lines        30667   30667           
  Branches      4597    4597           
=======================================
  Hits         13893   13893           
  Misses       16774   16774

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 04f4b8f...8333da1. Read the comment docs.

@apb7
Copy link
Contributor

apb7 commented Dec 18, 2018

@nithusha21: Weird. I am unable to merge this. Hi @BenHenning, if you're around, can you please approve and merge this. Thanks!

@brianrodri brianrodri mentioned this pull request Dec 19, 2018
Closed
6 tasks
@DubeySandeep DubeySandeep merged commit 85057a7 into oppia:develop Dec 19, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@apb7 apb7 apb7 approved these changes

@BenHenning BenHenning Awaiting requested review from BenHenning

@seanlip seanlip Awaiting requested review from seanlip

Assignees

@apb7 apb7

Labels
code-health
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@nithusha21 @codecov-io @apb7 @brianrodri @DubeySandeep