Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Disable mobile tests temporarily as per Issue #5839. #5992

Merged
merged 1 commit into from
Dec 17, 2018
Merged

Disable mobile tests temporarily as per Issue #5839. #5992

merged 1 commit into from
Dec 17, 2018

Conversation

apb7
Copy link
Contributor

@apb7 apb7 commented Dec 17, 2018

Explanation

See Issue #5839.

Checklist

  • The PR title starts with "Fix #bugnum: ", followed by a short, clear summary of the changes. (If this PR fixes part of an issue, prefix the title with "Fix part of #bugnum: ...".)
  • The PR explanation includes the words "Fixes #bugnum: ..." (or "Fixes part of #bugnum" if the PR only partially fixes an issue).
  • The linter/Karma presubmit checks have passed.
    • These should run automatically, but if not, you can manually trigger them locally using python scripts/pre_commit_linter.py and bash scripts/run_frontend_tests.sh.
  • The PR is made from a branch that's not called "develop".
  • The PR follows the style guide.
  • The PR is assigned to an appropriate reviewer.
    • If you're a new contributor, please ask on Gitter for someone to assign a reviewer.
    • If you're not sure who the appropriate reviewer is, please assign to the issue's "owner" -- see the "talk-to" label on the issue.

@apb7 apb7 requested a review from nithusha21 December 17, 2018 09:48
nithusha21
nithusha21 approved these changes Dec 17, 2018
View reviewed changes
Copy link
Contributor

@nithusha21 nithusha21 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM Thanks, @apb7. Just one question :)

.travis.yml
@@ -52,7 +52,8 @@ jobs:
# variables and are therefore not available for forks of the repository.
# For more details, refer to https://docs.travis-ci.com/user/environment-variables#encrypting-environment-variables
if: branch = develop AND type = push
env: RUN_E2E_TESTS_MOBILE=true
env: RUN_E2E_TESTS_MOBILE=false
# TODO(apb7): Enable mobile tests. See Issue #5839.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

TODOs are usually above where the action needs to be taken right?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Shall I put it before the if branching?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Or better so, on the same line as the env thing?

Copy link
Contributor

@nithusha21 nithusha21 Dec 17, 2018 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh the env has to immediately follow the if? In that case I think it is fine as is....

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am not sure about env immediately following the if but I haven't seen other examples, therefore the TODO below it.

@codecov-io
Copy link

Codecov Report

Merging #5992 into develop will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           develop   #5992   +/-   ##
=======================================
  Coverage     45.3%   45.3%           
=======================================
  Files          520     520           
  Lines        30667   30667           
  Branches      4597    4597           
=======================================
  Hits         13893   13893           
  Misses       16774   16774

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e8e14d5...0b99544. Read the comment docs.

@nithusha21 nithusha21 merged commit 9b6308a into oppia:develop Dec 17, 2018
@apb7 apb7 deleted the disable-mobile-tests branch December 17, 2018 11:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nithusha21 nithusha21 nithusha21 approved these changes

Assignees

@nithusha21 nithusha21

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@apb7 @codecov-io @nithusha21