Fix #5798: Introduce Improvements Tab to Exploration Editor #5991
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
brianrodri
changed the title
nithusha21
approved these changes
Dec 19, 2018
core/templates/dev/head/pages/collection_editor/CollectionEditorNavbarBreadcrumbDirective.js
Outdated
Show resolved
Hide resolved
core/templates/dev/head/pages/exploration_editor/improvements_tab/improvements_tab.html
Outdated
Show resolved
Hide resolved
brianrodri
dismissed
BenHenning’s stale review
All change requests have been resolved; awaiting next review.
s/improvements/issues
brianrodri
requested review from
aks681 and
BenHenning
and removed request for
BenHenning
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Improvements Tab Design Doc
This PR introduces the boilerplate to show the Improvements Tab on the exploration editor behind an admin-config boolean. When on, an additional "tab" will appear in the exploration editor's navigation.
The Improvements Tab is intentionally hard-coded; it will be populated in the future with meaningful data. The config value will be removed once the Improvements Tab is considered "complete".
Screenshots:
