Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Split ENABLE_NEW_STRUCTURES flag to 2 flags for editors and players #5987

Merged
merged 3 commits into from
Dec 16, 2018

Conversation

aks681
Copy link
Contributor

@aks681 aks681 commented Dec 15, 2018

In this PR, the ENABLE_NEW_STRUCTURES flag is split into 2 flags - ENABLE_NEW_STRUCTURE_EDITORS and ENABLE_NEW_STRUCTURE_PLAYERS and the usage in the various files have been changed accordingly.

@aks681 aks681 requested review from seanlip and tjiang11 December 15, 2018 20:01
@codecov-io
Copy link

Codecov Report

Merging #5987 into develop will not change coverage.
The diff coverage is 25%.

Impacted file tree graph

@@           Coverage Diff            @@
##           develop    #5987   +/-   ##
========================================
  Coverage    45.51%   45.51%           
========================================
  Files          518      518           
  Lines        30505    30505           
  Branches      4579     4579           
========================================
  Hits         13883    13883           
  Misses       16622    16622
Impacted Files Coverage Δ
...ts/top_navigation_bar/TopNavigationBarDirective.js 0.8% <0%> (ø) ⬆️
...ad/components/OutcomeDestinationEditorDirective.js 1.78% <0%> (ø) ⬆️
...ates/dev/head/components/OutcomeEditorDirective.js 1.03% <0%> (ø) ⬆️
...v/head/pages/creator_dashboard/CreatorDashboard.js 18.66% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e2756d8...fb27e34. Read the comment docs.

Copy link
Contributor

@tjiang11 tjiang11 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks @aks681 !

@tjiang11 tjiang11 merged commit c74a73c into oppia:develop Dec 16, 2018
@aks681 aks681 deleted the split-flags branch November 1, 2019 12:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants