Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix #5039: Added continue button in preview mode #5962

Merged
merged 2 commits into from
Dec 10, 2018
Merged

Fix #5039: Added continue button in preview mode #5962

merged 2 commits into from
Dec 10, 2018

Conversation

ankita240796
Copy link
Contributor

@ankita240796 ankita240796 commented Dec 8, 2018 •
edited
Loading

Explanation

Fixes #5039: Added continue button in preview mode.

Here is a screenshot for the same:
image

Checklist

  • The PR title starts with "Fix #bugnum: ", followed by a short, clear summary of the changes. (If this PR fixes part of an issue, prefix the title with "Fix part of #bugnum: ...".)
  • The PR explanation includes the words "Fixes #bugnum: ..." (or "Fixes part of #bugnum" if the PR only partially fixes an issue).
  • The linter/Karma presubmit checks have passed.
    • These should run automatically, but if not, you can manually trigger them locally using python scripts/pre_commit_linter.py and bash scripts/run_frontend_tests.sh.
  • The PR is made from a branch that's not called "develop".
  • The PR follows the style guide.
  • The PR is assigned to an appropriate reviewer.

@oppiabot
Copy link

oppiabot bot commented Dec 8, 2018

Hi! @ankita240796. Welcome to Oppia! Please could you follow the instructions here to get started ? You'll need to do this before we can accept your PR. Thanks!

@ankita240796
Copy link
Contributor Author

ankita240796 commented Dec 8, 2018 •
edited
Loading

Hi @nithusha21, @DubeySandeep

I get the response that I have already filled the CLA when I try to do so. Can you please help me with this, Thanks!

image

@codecov-io
Copy link

codecov-io commented Dec 8, 2018 •
edited
Loading

Codecov Report

Merging #5962 into develop will decrease coverage by <.01%.
The diff coverage is 0%.

Impacted file tree graph

@@             Coverage Diff             @@
##           develop    #5962      +/-   ##
===========================================
- Coverage    45.47%   45.47%   -0.01%     
===========================================
  Files          517      518       +1     
  Lines        30378    30496     +118     
  Branches      4571     4576       +5     
===========================================
+ Hits         13814    13867      +53     
- Misses       16564    16629      +65
Impacted Files Coverage Δ
...sions/interactions/Continue/directives/Continue.js 19.23% <0%> (-0.77%) ⬇️
...plates/dev/head/domain/state/StateObjectFactory.js 73.33% <0%> (-17.98%) ⬇️
...ead/domain/exploration/InteractionObjectFactory.js 75.92% <0%> (-11.04%) ⬇️
...nts/attribution_guide/AttributionGuideDirective.js 16.66% <0%> (-3.34%) ⬇️
...d/pages/question_editor/QuestionEditorDirective.js 2.77% <0%> (-0.68%) ⬇️
...s/exploration_player/ExplorationFooterDirective.js 4.54% <0%> (-0.22%) ⬇️
...es/topic_editor/questions/QuestionsTabDirective.js 0.52% <0%> (-0.13%) ⬇️
...main/question/EditableQuestionBackendApiService.js 74.41% <0%> (ø) ⬆️
...ev/head/domain/editor/undo_redo/UndoRedoService.js 100% <0%> (ø) ⬆️
.../dev/head/domain/question/QuestionUpdateService.js 100% <0%> (ø)
... and 3 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7126b42...3f81086. Read the comment docs.

@nithusha21
Copy link
Contributor

Hi @apb7 I think the bot incorrectly flagged this? Could you take a look? Thanks!

@nithusha21
Copy link
Contributor

A quick update here. Sandeep and I are looking into this. We have a record of the survey report, but not for the CLA.

bansalnitish
bansalnitish approved these changes Dec 8, 2018
View reviewed changes
Copy link
Contributor

@bansalnitish bansalnitish left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Functionality, LGTM!
I'll defer this to @nithusha21!

@bansalnitish
Copy link
Contributor

@nithusha21 could you take a pass over this ? (I think the CLA issue is resolved and we can merge after your pass)

nithusha21
nithusha21 reviewed Dec 10, 2018
View reviewed changes
Copy link
Contributor

@nithusha21 nithusha21 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The behavior LGTM.. Just one style comment.

extensions/interactions/Continue/directives/Continue.js Outdated
$scope.buttonText = HtmlEscaperService.escapedJsonToObj(
$attrs.buttonTextWithValue);

var DEFAULT_BUTTON_TEXT = 'Continue';
var DEFAULT_HUMAN_READABLE_ANSWER = 'Please continue.';

$scope.isInEditorMode = (
ContextService.isInExplorationEditorMode());
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This fits on one line right?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh, my bad! Fixed this.

nithusha21
nithusha21 approved these changes Dec 10, 2018
View reviewed changes
Copy link
Contributor

@nithusha21 nithusha21 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM Thanks!

@bansalnitish bansalnitish merged commit c9adae1 into oppia:develop Dec 10, 2018
@ankita240796 ankita240796 deleted the continue-fix branch December 10, 2018 19:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bansalnitish bansalnitish bansalnitish approved these changes

@nithusha21 nithusha21 nithusha21 approved these changes

Assignees
No one assigned
Labels
PR: LGTM
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Continue button preview missing in exploration editor
4 participants
@ankita240796 @codecov-io @nithusha21 @bansalnitish