Fix #5041 and #5033: Hide unresolved student answers when the exploration is private, since there is no data to show. #5080
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…e there is no data to show.
|
@kevinlee12 I've tested this, but please could you verify that this fixes the original issue(s)? Thanks! |
Codecov Report
@@ Coverage Diff @@
## develop #5080 +/- ##
===========================================
- Coverage 45.19% 45.18% -0.01%
===========================================
Files 408 408
Lines 23812 23816 +4
Branches 3850 3851 +1
===========================================
Hits 10761 10761
- Misses 13051 13055 +4
Continue to review full report at Codecov.
|
brianrodri
approved these changes
Jun 10, 2018
|
Thanks! |
|
I know it's been merged, but I do want to confirm that it's been fixed. |
tjiang11
pushed a commit
that referenced
this pull request
Jun 11, 2018
…e there is no data to show. (#5080)
hoangviet1993
pushed a commit
to hoangviet1993/oppia
that referenced
this pull request
Jun 20, 2018
…e there is no data to show. (oppia#5080)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes #5041, which is a blocking bug for the upcoming release. /cc @tjiang11 @kevinlee12
Checklist