Break up factories #5073
Merged
Break up factories #5073
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## develop #5073 +/- ##
========================================
Coverage 45.17% 45.17%
========================================
Files 397 408 +11
Lines 23794 23794
Branches 3848 3848
========================================
Hits 10748 10748
Misses 13046 13046
Continue to review full report at Codecov.
|
hoangviet1993
pushed a commit
to hoangviet1993/oppia
that referenced
this pull request
Jun 20, 2018
* Move ExplorationStatesService into its own file. * Split ExplorationCorrectnessFeedbackService into its own file. * Move ExplorationAutomaticTextToSpeechService into its own file. * Move ExplorationParamChangesServiceinto its own file. * Move ExplorationParamSpecsService into its own file. * Move ExplorationTagsService into its own file. * Move ExplorationInitStateNameService into its own file. * Move ExplorationLanguageCodeService into its own file. * Move ExplorationObjectiveService into its own file. * Move ExplorationCategoryService into its own file. * Remove ExplorationCategoryService from ExplorationPropertyService. * Move ExplorationTitleService into its own file. * Add references to new services
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The subclass factories in ExplorationPropertiesService were all grouped together since they shared so much code. However, this made finding them more difficult to find, and would result in enormous test files in our pursuit for higher coverage. Splitting them up will give us more flexibility and cleaner tests.