Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added deepcopy to change objects #5038

Merged
merged 1 commit into from
Jun 6, 2018
Merged

Added deepcopy to change objects #5038

merged 1 commit into from
Jun 6, 2018

Conversation

aks681
Copy link
Contributor

@aks681 aks681 commented Jun 5, 2018

Following comments in PR #5013 , in this PR, deepcopy is added for SkillChange, TopicChange and StoryChange objects.

@aks681 aks681 requested a review from seanlip June 5, 2018 19:26
Copy link
Member

@seanlip seanlip left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! LGTM.

@codecov-io
Copy link

Codecov Report

Merging #5038 into develop will increase coverage by <.01%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff             @@
##           develop    #5038      +/-   ##
===========================================
+ Coverage    45.19%   45.19%   +<.01%     
===========================================
  Files          397      397              
  Lines        23771    23773       +2     
  Branches      3849     3849              
===========================================
+ Hits         10743    10745       +2     
  Misses       13028    13028
Impacted Files Coverage Δ
...ev/head/domain/exploration/OutcomeObjectFactory.js 100% <0%> (ø) ⬆️
...ead/domain/exploration/AnswerGroupObjectFactory.js 100% <0%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e927554...617c323. Read the comment docs.

@aks681 aks681 merged commit 734aa0b into oppia:develop Jun 6, 2018
@aks681 aks681 deleted the add-copy branch June 6, 2018 14:40
hoangviet1993 pushed a commit to hoangviet1993/oppia that referenced this pull request Jun 20, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants