Improving the dev workflow: Milestone 1.1.1 Enable Pycodestyle rules and fix errors #4937
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Update Fork
Update Fork
Update Fork
Update Fork
Update Fork
Update Fork
Update fork
Update fork
Update fork
Update fork
Update fork
Update Fork
Update fork
Update fork
Update fork
Codecov Report
@@ Coverage Diff @@
## develop #4937 +/- ##
========================================
Coverage 44.16% 44.16%
========================================
Files 386 386
Lines 23289 23289
Branches 3789 3789
========================================
Hits 10286 10286
Misses 13003 13003Continue to review full report at Codecov.
|
kevinlee12
suggested changes
May 14, 2018
core/controllers/editor_test.py
Outdated
| @@ -1659,7 +1659,7 @@ def test_draft_not_updated_validation_error(self): | |||
| '%s.%s' % (self.owner_id, self.EXP_ID2)) | |||
| self.assertEqual( | |||
| exp_user_data.draft_change_list, self.DRAFT_CHANGELIST) | |||
| #id is incremented the first time but not the second. | |||
| #id is incremented the first time but not the second. | |||
| @@ -236,8 +236,8 @@ def print_details(self): | |||
| """Helper function to print details for all the events.""" | |||
| if self.page_session_stats: | |||
| print 'Total number of requests: %d' % self.get_request_count() | |||
| print ('Total page size in bytes: %d' | |||
| % self.get_total_page_size_bytes()) | |||
| print('Total page size in bytes: %d' | |||
There was a problem hiding this comment.
This will unfortunately change our print style (since we don't use print(...) convention). Since the Google Style guide on strings do allow the old method, we should follow it. Will it be possible to make an exception for this type of rule?
There was a problem hiding this comment.
This goes for the same elsewhere.
There was a problem hiding this comment.
Reverted this at all places. Thanks!
|
Thank you, @kevinlee12! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Explanation
Checklist
python scripts/pre_commit_linter.pyandbash scripts/run_frontend_tests.sh.