Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove reference to master branch from CHANGELOG #4852

Merged
merged 1 commit into from
Apr 7, 2018

Conversation

BenHenning
Copy link
Member

Removes the reference to https://github.com/oppia/oppia/commits/master from the CHANGELOG now that we don't have a master branch anymore.

We could update this to refer to develop instead, but that may includes commits not yet part of the true changelog. There doesn't seem to be a good way to show the latest release branch (best we can do is show the latest release, e.g. https://github.com/oppia/oppia/releases/latest). It seems better just to remove the suggestion altogether.

@BenHenning BenHenning requested review from seanlip and tjiang11 April 7, 2018 00:15
Copy link
Member

@seanlip seanlip left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@codecov-io
Copy link

codecov-io commented Apr 7, 2018

Codecov Report

Merging #4852 into develop will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff            @@
##           develop    #4852   +/-   ##
========================================
  Coverage    44.83%   44.83%           
========================================
  Files          387      387           
  Lines        23529    23529           
  Branches      3808     3808           
========================================
  Hits         10549    10549           
  Misses       12980    12980

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0912ca7...11731f9. Read the comment docs.

@seanlip seanlip merged commit a08d926 into develop Apr 7, 2018
@seanlip seanlip deleted the remove-master-branch-reference-from-changelog branch April 7, 2018 01:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants