Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add check for spaces in Python #4728

Merged
merged 3 commits into from
Feb 23, 2018
Merged

Add check for spaces in Python #4728

merged 3 commits into from
Feb 23, 2018

Conversation

apb7
Copy link
Contributor

@apb7 apb7 commented Feb 22, 2018

Explanation

This PR modifies the _check_def_spacing function to _check_spacing so that it now checks for missing whitespace after ',', ';' and ':'.

Checklist

  • The PR title starts with "Fix #bugnum: ", followed by a short, clear summary of the changes.
  • The PR explanation includes the words "Fixes #bugnum: ...".
  • The linter/Karma presubmit checks have passed.
    • These should run automatically, but if not, you can manually trigger them locally using python scripts/pre_commit_linter.py and bash scripts/run_frontend_tests.sh.
  • The PR is made from a branch that's not called "develop".
  • The PR follows the style guide.
  • The PR is assigned to an appropriate reviewer.
    • If you're a new contributor, please ask on Gitter for someone to assign a reviewer.
    • If you're not sure who the appropriate reviewer is, please assign to the issue's "owner" -- see the "talk-to" label on the issue.

@apb7 apb7 requested a review from seanlip February 22, 2018 23:22
Copy link
Member

@seanlip seanlip left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@codecov-io
Copy link

Codecov Report

Merging #4728 into develop will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff            @@
##           develop    #4728   +/-   ##
========================================
  Coverage    44.66%   44.66%           
========================================
  Files          384      384           
  Lines        23432    23432           
  Branches      3799     3799           
========================================
  Hits         10467    10467           
  Misses       12965    12965

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6689fce...5d979f7. Read the comment docs.

@seanlip seanlip merged commit d892834 into oppia:develop Feb 23, 2018
@apb7
Copy link
Contributor Author

apb7 commented Feb 23, 2018

Thank you, @seanlip!

@apb7 apb7 deleted the space-check branch February 23, 2018 03:11
code247 pushed a commit to code247/oppia that referenced this pull request Feb 24, 2018
code247 pushed a commit to code247/oppia that referenced this pull request Feb 24, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants