Fix #4701: fixes rule descriptor for ListOfCodeEvaluation and SetOfNormalizedStrings #4703
Conversation
core/templates/dev/head/filters.js
Outdated
| } | ||
| replacementText += ']'; | ||
| } | ||
| else { |
|
(and thanks, @prasanna08!) |
Codecov Report
@@ Coverage Diff @@
## develop #4703 +/- ##
==========================================
- Coverage 44.72% 44.7% -0.02%
==========================================
Files 384 384
Lines 23405 23414 +9
Branches 3791 3794 +3
==========================================
Hits 10467 10467
- Misses 12938 12947 +9
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Thanks for fixing this @prasanna08! Code LGTM. I have one query though. I am unable to get to these rules while manually testing them. Do I have to enable them somewhere else separately?
Yes, these errors would not be visible normally because these rule types are used when classifier training data is stored in exploration. This is not enabled in production right now so you will have to turn up constants related to ML in feconf.py and app.js. Then you would have to create some training data and these errors would surface because variable type used by these rules does not have a corresponding substitution code in |
|
Thanks for that information @prasanna08 I'll try that out 👍 |
…tOfNormalizedStrings (oppia#4703) * Fix rule desciptor for ListOfCodeEvaluation and SetOfNormalizedStrings * Address review comments
…tOfNormalizedStrings (oppia#4703) * Fix rule desciptor for ListOfCodeEvaluation and SetOfNormalizedStrings * Address review comments
This PR fixes rule descriptors of
ListOfCodeEvaluationandSetOfNormalizedStringsvariable types.