Fix #4293: Add slide animation to audio bar directive" #4636
Conversation
Codecov Report
@@ Coverage Diff @@
## develop #4636 +/- ##
=======================================
Coverage 44.7% 44.7%
=======================================
Files 384 384
Lines 23414 23414
Branches 3794 3794
=======================================
Hits 10467 10467
Misses 12947 12947Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Hi @LanJosh , thanks! It generally looks great but I have a little bit of a nitpick. When I expand the audio bar, it looks like the little tab that you press to collapse the audio bar starts at the top and then immediately shifts to the bottom of the audio bar. Would it be possible to have that slide as well? Thanks!
|
Hi @LanJosh , how's this going? |
|
Not having too much luck so far getting the audio collapse button to slide along with the audio controls. I think they are both brought in at the same time I can't seem to get the button to slide in the center or with the same timing as the audio controls but I'm not certain there's no way to do so yet. |
|
Would it be possible to join both the button and controls into a single
component that slides as a whole?
|
|
I had considered merging the two but then I believe the entire bar would capture the click event for collapsing. I'm going to try putting them in a container div and hiding/animating that instead |
|
Ah yes, that sounds like a better idea. Thanks @LanJosh! |
|
@tjiang11 PTAL! |
| @@ -70,6 +70,8 @@ | |||
| .audio-collapse-button { | |||
| height: 10px; | |||
| width: 30px; | |||
| top: 44px; | |||
| position: absolute; | |||
There was a problem hiding this comment.
Order CSS attributes alphabetically.
* Fix oppia#4293: Add slide animation to audio bar directive" * Slide audio collapse button alongside audio bar * Alphabetize CSS properties
* Fix oppia#4293: Add slide animation to audio bar directive" * Slide audio collapse button alongside audio bar * Alphabetize CSS properties
Added slide animation to the audio bar direction #4293