Fix #4579: Prevent hints from being released after correct answer is submitted. #4580
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
seanlip
approved these changes
Jan 20, 2018
There was a problem hiding this comment.
LGTM, thanks @tjiang11!
@DubeySandeep, could you please do a second review?
|
Also, @tjiang11 -- any chance we could add Karma tests for this? Not sure how feasible it is with the $on stuff, but might be worth trying. |
|
It's probably doable, won't be able to take a look again until later tonight however |
DubeySandeep
approved these changes
Jan 20, 2018
Codecov Report
@@ Coverage Diff @@
## develop #4580 +/- ##
===========================================
+ Coverage 44.76% 44.77% +<.01%
===========================================
Files 382 382
Lines 23197 23202 +5
Branches 3724 3725 +1
===========================================
+ Hits 10385 10389 +4
- Misses 12812 12813 +1
Continue to review full report at Codecov.
|
|
OK, thanks @tjiang11! Let me bring this in for now and do a hotfix -- it'd be great if we could add the karma test in later. |
seanlip
pushed a commit
that referenced
this pull request
Jan 21, 2018
giritheja
added a commit
to giritheja/oppia
that referenced
this pull request
Jan 23, 2018
* upstream/develop: (77 commits) Add test to HintAndSolutionManagerService to check that hints aren't released after a correct answer is submitted. (oppia#4585) Chance cancel property in SpeechSynthesisChunkerService into its own variable. (oppia#4591) Enable indent for func-expr (oppia#4588) Update text of refresher exp modal. (oppia#4584) Update content-type for JSON responses. (oppia#4583) Prevent hints from being released after correct answer is submitted. (oppia#4580) Change fraction placeholder when no integer part is allowed. (oppia#4581) Fix oppia#4567: Changed condition to check range enclosed criteria, edited existing test (oppia#4575) Fix part of oppia#3905: Added semi-rule (oppia#4576) Adds proper message for validation error in skill ID. (oppia#4577) Fix part of oppia#3905: Add checks for correct docstring style. (oppia#4572) Fix part of oppia#4374: Add docstrings to core.domain.collection_domain. (oppia#4569) Add check to prevent 'SpeechSynthesisUtterance is undefined' error. (oppia#4571) Fix of oppia#2533: Modified the stripFormatting filter to preserve newlines in RTE cut-and-paste (oppia#4568) Fix part of oppia#3905: Add check for console.log statement (oppia#4564) Change Java prerequisite to v8 (oppia#4570) Fix oppia#1542: RTE Components correctly displayed in answer group header (oppia#4565) Fix part of oppia#4374: Add docstrings to core.domain.param_domain (oppia#4551) Fix oppia#4555: Address review comments for oppia#4536. (oppia#4556) Update changelog, AUTHORS, CONTRIBUTORS and credits. (oppia#4560) ...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#4579
Checklist
python scripts/pre_commit_linter.pyandbash scripts/run_frontend_tests.sh.