Fix a flaky protractor test. #4347
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Requesting a review from anyone on @oppia/committers who's comfortable doing so, since this is a trivial change that unblocks some PRs. |
|
Thanks! |
apb7
pushed a commit
that referenced
this pull request
Jun 6, 2018
…custom_lint_checks.py (#5034) * ncluded docstrings in various functions in scrips/custom_lint_checks.py * Removed an extra line in custom_lint_checks.py * Removed an extra line in custom_lint_checks.py * Rectified the requested changes * Rectified the requested changes * Rectified the requested changes * Rectified the requested changes * Rectified the requested changes * Rectified the requested changes * Rectified the requested changes * Rectified the requested changes * Rectified the requested changes * Rectified the requested changes * Rectified the requested changes
hoangviet1993
pushed a commit
to hoangviet1993/oppia
that referenced
this pull request
Jun 20, 2018
…rips/custom_lint_checks.py (oppia#5034) * ncluded docstrings in various functions in scrips/custom_lint_checks.py * Removed an extra line in custom_lint_checks.py * Removed an extra line in custom_lint_checks.py * Rectified the requested changes * Rectified the requested changes * Rectified the requested changes * Rectified the requested changes * Rectified the requested changes * Rectified the requested changes * Rectified the requested changes * Rectified the requested changes * Rectified the requested changes * Rectified the requested changes * Rectified the requested changes
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The protractor test file was clicking an element directly instead of using a standard method in the editor.js protractor_utils page which included a post-click wait. This caused the next action to be attempted before the modal closed, which is resulting in flaky tests.
Checklist