Fix #4247: Fix feedback popover selector #4248
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
/cc @GanitGenius |
Codecov Report
@@ Coverage Diff @@
## develop #4248 +/- ##
========================================
Coverage 44.53% 44.53%
========================================
Files 368 368
Lines 22494 22494
Branches 3561 3561
========================================
Hits 10018 10018
Misses 12476 12476
Continue to review full report at Codecov.
|
nithusha21
approved these changes
Dec 23, 2017
giritheja
added a commit
to giritheja/oppia
that referenced
this pull request
Dec 27, 2017
…t-p2 * upstream/develop: Change http to https in various places. (oppia#4268) Fix oppia#3978: Added correct message for no incomplete explorations. (oppia#4264) Fix oppia#4260: Remove uib-collapse property from navbar (oppia#4262) For mobile: remove progress dots and replace with arrows for lesson playback (oppia#4265) Add an additional checkbox to the PR template to verify the branch name. (oppia#4263) Fix oppia#1270: earlier non-inline interactions still interactive (oppia#4232) corrected variable name collection summary_dicts (oppia#4256) Fix part of oppia#4057 - Test frontend services in domain/classifier (oppia#4246) Fix feedback popover selector (oppia#4248) Fix oppia#3787 and # 3788 (oppia#4185) Upgrade ui bootstrap (oppia#4230) Fix oppia#4143: Align buttons on splash page properly (oppia#4241) Run only the production e2e tests. (oppia#4239) Fix oppia#4065: New editor logout handler (oppia#4211)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change the for the feedback popup which was not being caught (#4247)
Checklist
python scripts/pre_commit_linter.pyandbash scripts/run_frontend_tests.sh.