Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix part of #3825: Rename angular services in Group 5 #4111

Merged
merged 11 commits into from
Nov 25, 2017
Merged

Fix part of #3825: Rename angular services in Group 5 #4111

merged 11 commits into from
Nov 25, 2017

Conversation

shubha1593
Copy link
Contributor

Fix part of #3825 : Rename angular services in Group 5 to follow UpperCamelCase convention.

@codecov-io
Copy link

codecov-io commented Nov 25, 2017 •
edited
Loading

Codecov Report

Merging #4111 into develop will not change coverage.
The diff coverage is 27.08%.

Impacted file tree graph

@@           Coverage Diff            @@
##           develop    #4111   +/-   ##
========================================
  Coverage    43.92%   43.92%           
========================================
  Files          355      355           
  Lines        22308    22308           
  Branches      3541     3541           
========================================
  Hits          9799     9799           
  Misses       12509    12509
Impacted Files Coverage Δ
.../collection/SearchExplorationsBackendApiService.js 100% <ø> (ø) ⬆️
...n_editor/editor_tab/SolutionVerificationService.js 100% <ø> (ø) ⬆️
core/templates/dev/head/pages/library/Library.js 29.78% <ø> (ø) ⬆️
...pages/exploration_player/FeedbackPopupDirective.js 1.96% <ø> (ø) ⬆️
...ad/components/VersionDiffVisualizationDirective.js 0.78% <ø> (ø) ⬆️
...s/exploration_editor/editor_tab/StateStatistics.js 4.54% <ø> (ø) ⬆️
.../pages/exploration_player/StatsReportingService.js 2.97% <ø> (ø) ⬆️
...text_components/Image/directives/ImageDirective.js 8.33% <ø> (ø) ⬆️
...ions/interactions/EndExploration/EndExploration.js 13.88% <0%> (ø) ⬆️
...es/exploration_editor/EditorNavigationDirective.js 2.32% <0%> (ø) ⬆️
... and 63 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 039f024...7ff2e09. Read the comment docs.

@shubha1593 shubha1593 requested a review from seanlip November 25, 2017 16:49
seanlip
seanlip approved these changes Nov 25, 2017
View reviewed changes
Copy link
Member

@seanlip seanlip left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks very much, @shubha1593!

@seanlip seanlip merged commit 57a5dd0 into oppia:develop Nov 25, 2017
@shubha1593 shubha1593 deleted the rename-services branch November 29, 2017 19:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@seanlip seanlip seanlip approved these changes

Assignees
No one assigned
Labels
PR: LGTM
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@shubha1593 @codecov-io @seanlip