Fix #3792 Add underline to 'Back to collection' link #4096
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## develop #4096 +/- ##
========================================
Coverage 43.93% 43.93%
========================================
Files 355 355
Lines 22299 22299
Branches 3541 3541
========================================
Hits 9798 9798
Misses 12501 12501Continue to review full report at Codecov.
|
seanlip
approved these changes
Nov 21, 2017
There was a problem hiding this comment.
I've just tested this, and in light of the new design direction in #4076, this looks good. Thanks @sriordan9, and congrats on your first code contribution to Oppia!
|
Thanks for the opportunity/help! |
giritheja
added a commit
to giritheja/oppia
that referenced
this pull request
Nov 25, 2017
…t-p2 * upstream/develop: (129 commits) Fix 3946: Add visualization for Item selection inputs (oppia#4080) Remove feedback button from mobile learner view. (oppia#4093) Fix oppia#3289: Introduce domain objects for answer calculation output (oppia#4036) Renamed RTC_specs to RTC_definitions and removed useless __init__.py file. (oppia#4101) Fix exploration graph directive URL. (oppia#4098) Fix error in one off stats migration job. (oppia#4068) Add state id mapping mapreduce job to the job registry (oppia#4099) Added underline to 'Back to collection' link (oppia#4096) Minor updates to CHANGELOG v2.5.6 after proofreading (oppia#4097) Update Authors, Contributors, Changelog, Credits for Release 2.5.6. (oppia#4095) Prevent hint tooltip from going offscreen on mobile (oppia#4087) Implement one off MapRreduce job to generate state id mapping model for explorations. (oppia#4088) Routine update of translations. (oppia#4082) Fix part of oppia#3954: Created a Page Object for Thanks Page (oppia#4085) Rename CSS property oppia-learner-continue-button to oppia-learner-confirm-button; Make the Submit button in ItemSelectionInput the same style as the Continue button; Move informational text in ItemSelectionInput from bottom-right to top of the interaction so that it is more visible; Add extra text to ItemSelectionInput indicating to the learner that they may select more than one choice. (oppia#4083) Stop cards from going offscreen in mobile learner view. (oppia#4084) Upgrade SSL library version; remove obsolete challenge-response handler. (oppia#4081) Fix part of oppia#3826: extract from EditorServices.js (oppia#3970) Fix part of oppia#3826: Extract services from app.js (oppia#4079) Fix oppia#4055: Replaced redundant CSS selectors. (oppia#4059) ...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@seanlip The only reason for the margin-top change was to move it below margin-bottom in keeping with the CSS styling rules of alphabetical attribute order.