Remove gadgets functionality and update the exploration schema version accordingly. #3801
Conversation
|
/cc @BenHenning. The exploration migration job needs to be run for the next release. |
Codecov Report
@@ Coverage Diff @@
## develop #3801 +/- ##
===========================================
+ Coverage 45.88% 46.19% +0.31%
===========================================
Files 280 275 -5
Lines 21167 20703 -464
Branches 3293 3232 -61
===========================================
- Hits 9712 9564 -148
+ Misses 11455 11139 -316
Continue to review full report at Codecov.
|
| gadget_instance = exploration.get_gadget_instance_by_name( | ||
| change.gadget_name) | ||
| if (change.property_name == | ||
| exp_domain.GADGET_PROPERTY_VISIBILITY): |
There was a problem hiding this comment.
Remove this constant in exp_domain? (and GADGET_PROPERTY_CUST_ARGS)
There was a problem hiding this comment.
Thanks @tjiang11! I thought I put it under the "these four properties are deprecated" part, though -- is that the one you mean? The idea is to prevent others using them as keys in the future.
There was a problem hiding this comment.
Also, @tjiang11 -- if this sounds OK to you, please go ahead and merge. Don't want to delay it too much since this PR is large and prone to merge conflicts.
Thanks!
There was a problem hiding this comment.
Ohh I see, okay that makes sense
No description provided.