Fix user bios job in the case that user_bio is None #3632
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## develop #3632 +/- ##
========================================
Coverage 44.84% 44.84%
========================================
Files 257 257
Lines 19873 19873
Branches 3132 3132
========================================
Hits 8913 8913
Misses 10960 10960Continue to review full report at Codecov.
|
wxyxinyu
added a commit
that referenced
this pull request
Jul 9, 2017
giritheja
added a commit
to giritheja/oppia
that referenced
this pull request
Jul 16, 2017
…date * upstream/develop: (32 commits) Remove erroneous clause in app.yaml. (oppia#3643) Part of oppia#2447: Upgrade select2 library (oppia#3626) Fix part of oppia#2394: Added docstrings in exp_domain.py (oppia#3578) Fix oppia#3618: stop icon overlap (oppia#3642) Add backend functionality to correctly handle needs_update part of subtitled HTML. (oppia#3620) Change 'style' to 'ng-attr-style' in an attempt to fix IE bug in collection viewer. (oppia#3636) Fix typo in Exploration editor (oppia#3637) Update credits (oppia#3633) Fix oppia#2639: Updated Google chart/visualization Library loader code and use async to load the library (oppia#3614) Fix user bios job in the case that user_bio is None (oppia#3632) Update changelog and credits for release 2.5.2 (oppia#3628) Fix oppia#2394: Add docstring to core.domain.user_jobs_continous.py (oppia#3569) Fix oppia#3585: Corrected arrows in exploration progress nav (oppia#3605) change the text edit error message Corrected tense of error message Corrected state to read card Close modal window if clicked outside (oppia#3623) Storage, Domain classes and helper functions for ClassifierExplorationMapping (oppia#3583) removed super admin role from admin interface. (oppia#3621) ...
ctao5660
pushed a commit
to ctao5660/oppia
that referenced
this pull request
Nov 23, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We have some legacy data where the user_bio field of the UserSettingsModel for some older users can be None. This PR is to handle that case.