Change error message in editor #3629
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## develop #3629 +/- ##
===========================================
- Coverage 44.85% 44.84% -0.01%
===========================================
Files 257 257
Lines 19871 19873 +2
Branches 3131 3132 +1
===========================================
Hits 8913 8913
- Misses 10958 10960 +2
Continue to review full report at Codecov.
|
jacobdavis11
suggested changes
Jul 9, 2017
| 'Please add feedback for the user if they are to return to the ' + | ||
| 'same state again.') | ||
| 'Please add feedback for the user in the [All other answers] ' + | ||
| 'rule if they are to return to the same state again.') |
There was a problem hiding this comment.
I suggest removing "if they are to return to the same state again" as currently it sounds like a conditional - i.e. the editor has to determine whether the user would return to the same state again, and if so fix things.
There was a problem hiding this comment.
Changed it, please take a look again.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This changes the error message in the editor to clarify where the author should add feedback in the case where the default rule has no feedback.