Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Release 2.4.2 #3357

Merged
merged 194 commits into from
Apr 23, 2017
Merged

Release 2.4.2 #3357

merged 194 commits into from
Apr 23, 2017

Conversation

wxyxinyu
Copy link
Contributor

No description provided.

pranavsid98 and others added 23 commits April 12, 2017 14:57
…der bubble in editor. (#3277)

* Change color combination required for visibility of reminder bubble in editor

* Added scoped css

* Add changes in css to make class unique
* Create ParamChange object

* Lint

* Convert exploration param changes to front end representation

* converting exploration param changes to backend

* Lint

* Remove console logs

* remove function

* decouple fields in directive

* move angular copy into factory

* updates
….py in delete method (#3275)

* Fixes : removed role from get request and used self.is_admin and self.is_moderator instead

* added test to check the logging after deletion of exploration

* Requested changes made in editor_test.py

* comments added

* comment updated
Fix #3282: Fixes the validate() function for LDAStringClassifier
…ions for creator dashboard (#3196)

* Fix#2160 Introduce final version of tests involving deleting explorations
for creator dashboard

* Fix#2160 Added required changes for tests involving deleting exploration from creator's dashboard

* Fixed #2160 final review needed for changes as suggested

* Fix#2160 Removed errors mentioned in the log

* Fix#2160 finally all tests are passed locally please review it

* Fix #2160 ready to merge please review it

* Fixed #2160 Done minor changes as suggested

* Fixed#2160 Resolved Linting Errors

* Fixed #2160 ready to merge please review
@codecov-io
Copy link

codecov-io commented Apr 23, 2017

Codecov Report

Merging #3357 into master will increase coverage by 1.14%.
The diff coverage is 65.93%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #3357      +/-   ##
==========================================
+ Coverage   44.82%   45.96%   +1.14%     
==========================================
  Files         230      240      +10     
  Lines       18644    18398     -246     
  Branches     3053     2955      -98     
==========================================
+ Hits         8357     8457     +100     
+ Misses      10287     9941     -346
Impacted Files Coverage Δ
...tensions/interactions/ImageClickInput/validator.js 100% <ø> (ø) ⬆️
extensions/interactions/GraphInput/validator.js 90% <ø> (ø) ⬆️
...pages/exploration_editor/preview_tab/PreviewTab.js 2% <ø> (+0.07%) ⬆️
...ev/head/pages/exploration_editor/RouterServices.js 0.92% <ø> (ø) ⬆️
...ges/exploration_editor/feedback_tab/FeedbackTab.js 0.72% <ø> (ø) ⬆️
extensions/interactions/CodeRepl/CodeRepl.js 36.15% <ø> (ø) ⬆️
...lates/dev/head/services/autoplayedVideosService.js 14.28% <ø> (ø) ⬆️
...lates/dev/head/expressions/expressionSyntaxTree.js 98.71% <ø> (ø) ⬆️
extensions/interactions/GraphInput/GraphInput.js 38.76% <ø> (ø) ⬆️
extensions/gadgets/ScoreBar/ScoreBar.js 7.14% <ø> (ø) ⬆️
... and 142 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 22ec97a...678f75e. Read the comment docs.

Copy link
Member

@seanlip seanlip left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. (Wow, big release!)

@seanlip seanlip merged commit 3450372 into master Apr 23, 2017
@wxyxinyu wxyxinyu deleted the release-2.4.2 branch April 23, 2017 15:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.