Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix #3329: 'Error 404: Page not found' has broken footer #3354

Merged
merged 3 commits into from
Apr 27, 2017
Merged

Fix #3329: 'Error 404: Page not found' has broken footer #3354

merged 3 commits into from
Apr 27, 2017

Conversation

shaz13
Copy link
Contributor

@shaz13 shaz13 commented Apr 22, 2017 •
edited
Loading

#3329
The Error 404: Page not found has broken footer,

How to produce

  1. Go to any address which is not a page at Oppia, Eg http://localhost:8181/ighiu

screenshot from 2017-04-12 21-05-21

This PR's commit

screenshot from 2017-04-22 14-32-38

@shaz13 shaz13 self-assigned this Apr 22, 2017
@shaz13 shaz13 requested a review from Oishikatta April 22, 2017 09:04
@codecov-io
Copy link

codecov-io commented Apr 22, 2017 •
edited
Loading

Codecov Report

Merging #3354 into develop will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff            @@
##           develop    #3354   +/-   ##
========================================
  Coverage    45.98%   45.98%           
========================================
  Files          240      240           
  Lines        18403    18403           
  Branches      2951     2951           
========================================
  Hits          8463     8463           
  Misses        9940     9940

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update dcf8be4...faf6a54. Read the comment docs.

seanlip
seanlip reviewed Apr 22, 2017
View reviewed changes
core/templates/dev/head/pages/error/error.html Outdated
@@ -64,6 +64,14 @@ <h2 class="oppia-error-h2" translate="I18N_ERROR_MESSAGE_500"></h2>
font-size: 1.17em;
font-weight: 700;
}
.oppia-footer {
position: absolute;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Indent by 2.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done

seanlip
seanlip reviewed Apr 22, 2017
View reviewed changes
core/templates/dev/head/pages/error/error.html Outdated
}
@media (max-width: 768px) {
.oppia-footer {
position: relative;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Indent by 2.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done

@seanlip
Copy link
Member

seanlip commented Apr 26, 2017

@Oishikatta, PTAL?

Oishikatta
Oishikatta approved these changes Apr 26, 2017
View reviewed changes
Copy link
Contributor

@Oishikatta Oishikatta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested and works well for me. Code LGTM.

@shaz13
Copy link
Contributor Author

shaz13 commented Apr 27, 2017

@seanlip PR seems good to go. Kindly confirm

@seanlip seanlip merged commit cb707c5 into oppia:develop Apr 27, 2017
@shaz13 shaz13 deleted the Footer-fix-404-error branch April 27, 2017 18:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@seanlip seanlip seanlip left review comments

@Oishikatta Oishikatta Oishikatta approved these changes

Assignees

@shaz13 shaz13

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@shaz13 @codecov-io @seanlip @Oishikatta