Fix broken backend test. #3208
Merged
Fix broken backend test. #3208
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi @tjiang11 -- I figured out the backend test issue. It's actually quite amusing, and now I know why there was a discrepancy :) PTAL? |
Codecov Report
@@ Coverage Diff @@
## develop #3208 +/- ##
========================================
Coverage 45.82% 45.82%
========================================
Files 230 230
Lines 18140 18140
Branches 2933 2933
========================================
Hits 8313 8313
Misses 9827 9827Continue to review full report at Codecov.
|
giritheja
added a commit
to giritheja/oppia
that referenced
this pull request
Mar 19, 2017
* upstream/develop: (41 commits) Fix naming error in PR 3202. (oppia#3220) Add e2e tests for suggestion acceptance on explorations (oppia#3202) Fix oppia#3180: Fixing issues with the teachOppiaModal. (oppia#3181) Fix oppia#2394: Add useful docstrings to core/storage/job/gae_models.py (oppia#3195) Fixes oppia#3192: shifted back css of oppia-sidebar-menu-open back to oppia.css (oppia#3211) Add test (oppia#3217) Add a check that user contributions for logged in users exist on the home page redirect check (oppia#3213) Fix part of oppia#2863: Create front-end fallback domain object (oppia#3207) Fix broken backend test. (oppia#3208) Fix oppia#3162: set expiration explicitly for files in the build directory. (oppia#3203) Add exception for updating user first contribution time for migration bot (oppia#3206) Fix oppia#3101: Discard-draft Tooltip (oppia#3205) added back formbuilder js in admin.html retained formbuilder.js in base.html Fix oppia#3099: Clarify error message for Item Selection and Multiple Choice interaction (oppia#3184) Resize image region code refactor Bump the version number to v2.4.1 and update the changelog Add new contributors to AUTHORS, CONTRIBUTORS and about.html Fix part of oppia#2863: Create front-end domain object for Interactions (oppia#3049) Fix part of oppia#2394: Added docstrings in cron.py (oppia#3182) ...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.