Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix translatewiki attirbution in credits #2916

Merged
merged 2 commits into from
Jan 12, 2017
Merged

Fix translatewiki attirbution in credits #2916

merged 2 commits into from
Jan 12, 2017

Conversation

wxyxinyu
Copy link
Contributor

No description provided.

@wxyxinyu wxyxinyu requested a review from seanlip January 12, 2017 03:45
@@ -408,6 +406,10 @@
Rahim Nathwani, Robyn Choo, Tricia Ngoon, Vikrant Nanda,
Vinamrata Singal and Yarin Feigenbaum.
</p>

<p>
We would also like to thank <a href="https://translatewiki.net">translatewiki.net</a> for providing crowdsourced translations.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe this is a better page to link to? https://translatewiki.net/wiki/Translating:Oppia

Copy link
Member

@seanlip seanlip left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks! just one small suggestion

@codecov-io
Copy link

codecov-io commented Jan 12, 2017

Current coverage is 46.41% (diff: 100%)

Merging #2916 into master will increase coverage by 0.13%

@@             master      #2916   diff @@
==========================================
  Files           227        226     -1   
  Lines         17761      17691    -70   
  Methods        3185       3154    -31   
  Messages          0          0          
  Branches       2875       2871     -4   
==========================================
- Hits           8220       8212     -8   
+ Misses         9541       9479    -62   
  Partials          0          0          

Powered by Codecov. Last update 6ce0389...dd83462

@seanlip seanlip merged commit 900521a into master Jan 12, 2017
@seanlip seanlip deleted the hotfix-credits branch January 12, 2017 08:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants