Fix one more unicode error. Modify test so these errors don't recur in the future. Change color of admin banner page to differentiate it from the main server. #2512
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…n the future. Change color of admin banner page to differentiate it from the main server.
BenHenning
requested changes
Sep 26, 2016
| @@ -1240,8 +1240,8 @@ def reduce(key, stringified_values): | |||
| yield ( | |||
| 'Item ID: %s, last updated: %s, state name: %s, ' | |||
| 'exp id: %s, error: %s' % ( | |||
| item_id, last_updated, state_name, exploration_id, | |||
| error)) | |||
| item_id, last_updated, state_name.encode('utf-8'), | |||
There was a problem hiding this comment.
Should we also be encoding state_name when it's being logged to the new storage model?
There was a problem hiding this comment.
I don't think so. We only need to encode it when we are displaying it. The state_name that's being logged to the storage model is the same that is logged to the 'states' property of an Exploration storage model.
BenHenning
approved these changes
Sep 26, 2016
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@BenHenning: Note that this change clears all remaining errors (at least for the exploration I tested locally).