Update wording on Teach page; fix CSS on Teach and About pages. #2323
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Current coverage is 48.01% (diff: 100%)@@ develop #2323 diff @@
==========================================
Files 190 190
Lines 15969 15969
Methods 2747 2747
Messages 0 0
Branches 2707 2707
==========================================
Hits 7667 7667
Misses 8302 8302
Partials 0 0
|
| margin-right: 20px; | ||
| width: calc((100% - 40px) / 3); | ||
| width: calc((100% - 60px) / 3); |
There was a problem hiding this comment.
Might be best to provide a default width in case there are those with legacy browsers.
|
Hi @seanlip, looks great, just a small note. :) |
|
Done, thanks! PTAL. |
|
LGTM! thanks! |
wxyxinyu
pushed a commit
that referenced
this pull request
Aug 8, 2016
* Update wording on Teach page; fix CSS on Teach and About pages. * Add fallback for CSS calc rule.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.