Fix #2063: convert continuous jobs into one-off jobs. #2320
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
seanlip
changed the title
Current coverage is 47.97% (diff: 100%)@@ develop #2320 diff @@
==========================================
Files 190 190
Lines 15953 15953
Methods 2740 2740
Messages 0 0
Branches 2702 2702
==========================================
Hits 7654 7654
Misses 8299 8299
Partials 0 0
|
|
This looks great, thanks! |
| @@ -97,6 +99,27 @@ def get(self): | |||
| user_jobs_one_off.DashboardStatsOneOffJob.create_new()) | |||
|
|
|||
|
|
|||
| class CronExplorationRecommendationsHandler(base.BaseHandler): | |||
| """Handler for appending dashboard stats to a list.""" | |||
There was a problem hiding this comment.
This comment seems to be incorrect.
There was a problem hiding this comment.
Whoops, thanks for catching this, @526avijitgupta! Fixed in #2326, PTAL.
wxyxinyu
pushed a commit
that referenced
this pull request
Aug 8, 2016
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.