Alphabetize and limit GLOBALS to 80 chars in html #2275
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| DEFAULT_LANGUAGE_CODE: JSON.parse( | ||
| '{{DEFAULT_LANGUAGE_CODE|js_string}}'), | ||
| DEV_MODE: JSON.parse('{{DEV_MODE|js_string}}'), | ||
| INVALID_NAME_CHARS: JSON.parse('{{INVALID_NAME_CHARS|js_string}}'), | ||
| MINIFICATION: JSON.parse('{{MINIFICATION|js_string}}'), | ||
| RTE_COMPONENT_SPECS: JSON.parse('{{RTE_COMPONENT_SPECS|js_string}}'), |
There was a problem hiding this comment.
Oh, I see. I had assumed that https://github.com/oppia/oppia/pull/2275/files#diff-f66cda1f67929310d3b56713d450f96aR93 refers to all keys declared below it. Thus, didn't mix and match. But the comment is just for POST_COMPLETION_HOOKS, right ?
|
LGTM, thanks @526avijitgupta! I noticed one small thing, but feel free to merge after you fix it and Travis checks pass. |
Current coverage is 48.00%@@ develop #2275 diff @@
==========================================
Files 185 185
Lines 15852 15852
Methods 2720 2720
Messages 0 0
Branches 2689 2689
==========================================
Hits 7609 7609
Misses 8243 8243
Partials 0 0
|
wxyxinyu
pushed a commit
that referenced
this pull request
Aug 8, 2016
* Alphabetize and limit GLOBALS to 80 chars * Address review comment
ctao5660
pushed a commit
to ctao5660/oppia
that referenced
this pull request
Nov 23, 2018
* Alphabetize and limit GLOBALS to 80 chars * Address review comment
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As discussed in #2272
@seanlip Please review.