Fully use python on GitHub Actions #21671
Conversation
|
Assigning @kevintab95 for the first pass review of this PR. Thanks! |
|
Hi @seanlip, there are some failing CI checks in your latest push If you think this is due to a flake, please file an issue before restarting the tests. Thanks! |
|
🛠️ Hi @seanlip, it looks like the CI checks are failing on your PR. Please look at the logs and follow these instructions to fix them, or report the error as a flake. Thanks! |
|
Hi @seanlip, there are some failing CI checks in your latest push If you think this is due to a flake, please file an issue before restarting the tests. Thanks! |
1 similar comment
|
Hi @seanlip, there are some failing CI checks in your latest push If you think this is due to a flake, please file an issue before restarting the tests. Thanks! |
|
🛠️ Hi @seanlip, it looks like the CI checks are failing on your PR. Please look at the logs and follow these instructions to fix them, or report the error as a flake. Thanks! |
|
Hi @seanlip, there are some failing CI checks in your latest push If you think this is due to a flake, please file an issue before restarting the tests. Thanks! |
|
🛠️ Hi @seanlip, it looks like the CI checks are failing on your PR. Please look at the logs and follow these instructions to fix them, or report the error as a flake. Thanks! |
|
Hi @seanlip, there are some failing CI checks in your latest push If you think this is due to a flake, please file an issue before restarting the tests. Thanks! |
|
Hi @seanlip, there are some failing CI checks in your latest push If you think this is due to a flake, please file an issue before restarting the tests. Thanks! |
|
🛠️ Hi @seanlip, it looks like the CI checks are failing on your PR. Please look at the logs and follow these instructions to fix them, or report the error as a flake. Thanks! |
|
Hi @seanlip, there are some failing CI checks in your latest push If you think this is due to a flake, please file an issue before restarting the tests. Thanks! |
|
Unassigning @kevintab95 since they have already approved the PR. |
|
Hi @seanlip, this PR is ready to be merged. Please address any remaining comments prior to merging, and feel free to merge this PR once the CI checks pass and you're happy with it. Thanks! |
|
Hi @seanlip, there are some failing CI checks in your latest push If you think this is due to a flake, please file an issue before restarting the tests. Thanks! |
|
🛠️ Hi @seanlip, it looks like the CI checks are failing on your PR. Please look at the logs and follow these instructions to fix them, or report the error as a flake. Thanks! |
|
Hi @seanlip, there are some failing CI checks in your latest push If you think this is due to a flake, please file an issue before restarting the tests. Thanks! |
|
🛠️ Hi @seanlip, it looks like the CI checks are failing on your PR. Please look at the logs and follow these instructions to fix them, or report the error as a flake. Thanks! |
|
Hi @seanlip, there are some failing CI checks in your latest push If you think this is due to a flake, please file an issue before restarting the tests. Thanks! |
|
🛠️ Hi @seanlip, it looks like the CI checks are failing on your PR. Please look at the logs and follow these instructions to fix them, or report the error as a flake. Thanks! |
|
Hi @seanlip, there are some failing CI checks in your latest push If you think this is due to a flake, please file an issue before restarting the tests. Thanks! |
|
🛠️ Hi @seanlip, it looks like the CI checks are failing on your PR. Please look at the logs and follow these instructions to fix them, or report the error as a flake. Thanks! |
|
Hi @seanlip, there are some failing CI checks in your latest push If you think this is due to a flake, please file an issue before restarting the tests. Thanks! |
|
I need to merge this in order to unblock failing CI checks due to Redis issues. The main issue with this PR is that it increases the threshold needed for screenshot testing -- will discuss this with @imchristie in #21677. |
kevintab95
added
PR: for current release
PR: released
and removed
PR: for current release
PR: released
labels
This reverts commit 0bf1888.
Overview
Note: This PR Is being made because the "Initializing Containers" step on Docker is failing often on CI with errors that are hard to debug. These include:
failed to solve: process "/bin/sh -c apt-get update -y && apt-get upgrade -y curl git npm openjdk-11-jre python3-matplotlib unzip wget jq" did not complete successfully: exit code: 100(example)failed to solve: process "/bin/sh -c yarn install --pure-lockfile" did not complete successfully: exit code: 1(example)0.975 npm ERR! invalid json response body at https://registry.npmjs.org/typescript reason: Invalid response body while trying to fetch https://registry.npmjs.org/typescript: aborted(example)1.256 error Received malformed response from registry for "react-is". The registry may be down.(example)A possibility that I considered was to add a retry step to that action. However, I realized that this "initializing containers" step takes 8-10 minutes to run. In contrast, the Python setup + dependency installation step takes 1 minute.
There is therefore no performance or reliability advantage in using the Docker actions. So this PR removes them completely from the workflows and standardizes all the workflows to use a standard Python installation instead.
Essential Checklist
Please follow the instructions for making a code change.
Proof that changes are correct
This will be determined by the CI check runs.