Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update install_prerequisites scripts to match wiki #21642

Merged
merged 3 commits into from
Jan 10, 2025
Merged

Update install_prerequisites scripts to match wiki #21642

merged 3 commits into from
Jan 10, 2025

Conversation

seanlip
Copy link
Member

@seanlip seanlip commented Jan 6, 2025

Overview

  1. This PR fixes or fixes part of #N/A
  2. This PR does the following: Update install_prerequisites scripts to be consistent with the list in Update installation instructions, troubleshooting instructions, and CI check failure instructions. oppia-web-developer-docs#431. Note that I dropped some stuff from install_prerequisites.sh since GitHub Actions does not need it (it doesn't call the script during setup and everything still works).

Essential Checklist

Please follow the instructions for making a code change.

  • I have linked the issue that this PR fixes in the "Development" section of the sidebar.
  • I have checked the "Files Changed" tab and confirmed that the changes are what I want to make.
  • I have written tests for my code.
  • The PR title starts with "Fix #bugnum: " or "Fix part of #bugnum: ...", followed by a short, clear summary of the changes.
  • I have assigned the correct reviewers to this PR (or will leave a comment with the phrase "@{{reviewer_username}} PTAL" if I can't assign them directly).

Proof that changes are correct

A partial check is whether the Docker CI tests are passing since they make use of matplotlib, which was removed.

@seanlip seanlip requested a review from a team as a code owner January 6, 2025 03:30
@seanlip seanlip requested a review from Vir-8 January 6, 2025 03:30
@oppiabot OppiaBot
Copy link

oppiabot bot commented Jan 6, 2025

Assigning @Vir-8 for the first pass review of this PR. Thanks!

@oppiabot oppiabot bot assigned Vir-8 Jan 6, 2025
@seanlip seanlip enabled auto-merge January 6, 2025 03:33
seanlip
seanlip commented Jan 6, 2025
View reviewed changes
scripts/install_python_prod_dependencies.py
@@ -35,7 +35,6 @@
MismatchType = Dict[str, Tuple[Optional[str], Optional[str]]]
ValidatedMismatchType = Dict[str, Tuple[str, Optional[str]]]

# This is the version that is set in install_prerequisites.sh.
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not sure what this comment means, so I removed it (it doesn't seem to relate to the next line at all).

@oppiabot OppiaBot
Copy link

oppiabot bot commented Jan 7, 2025

Hi @seanlip, there are some failing CI checks in your latest push If you think this is due to a flake, please file an issue before restarting the tests. Thanks!

Vir-8
Vir-8 approved these changes Jan 8, 2025
View reviewed changes
Copy link
Contributor

@Vir-8 Vir-8 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@seanlip seanlip added this pull request to the merge queue Jan 8, 2025
@oppiabot oppiabot bot unassigned Vir-8 Jan 8, 2025
@oppiabot OppiaBot
Copy link

oppiabot bot commented Jan 8, 2025

Unassigning @Vir-8 since they have already approved the PR.

@oppiabot oppiabot bot added the PR: LGTM label Jan 8, 2025
@oppiabot OppiaBot
Copy link

oppiabot bot commented Jan 8, 2025

Hi @seanlip, this PR is ready to be merged. Please address any remaining comments prior to merging, and feel free to merge this PR once the CI checks pass and you're happy with it. Thanks!

@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Jan 8, 2025
@seanlip seanlip added this pull request to the merge queue Jan 8, 2025
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Jan 8, 2025
@seanlip seanlip enabled auto-merge January 9, 2025 17:42
@seanlip seanlip added this pull request to the merge queue Jan 9, 2025
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Jan 9, 2025
@seanlip seanlip added this pull request to the merge queue Jan 10, 2025
Merged via the queue into develop with commit f0bfbfd Jan 10, 2025
130 checks passed
@seanlip seanlip deleted the housekeeping branch January 10, 2025 02:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Vir-8 Vir-8 Vir-8 approved these changes

Assignees

@seanlip seanlip

Labels
PR: LGTM
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@seanlip @Vir-8